Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single Viem client for wallet & public #12254

Open
spypsy opened this issue Feb 25, 2025 · 0 comments
Open

Use single Viem client for wallet & public #12254

spypsy opened this issue Feb 25, 2025 · 0 comments
Assignees
@spypsy

Comments

@spypsy
Copy link
Member

spypsy commented Feb 25, 2025

Since we can simply extend a wallet client to perform public actions as well, we shouldn't need two separate vars, walletClient & publicClient.
We already use .extend(publicActions in a few places, we should do it everywhere that both clients are needed, and simply use a single client for all actions
@spypsy spypsy self-assigned this Feb 25, 2025
@spypsy spypsy mentioned this issue Feb 25, 2025
Merged
spypsy added a commit that referenced this issue Feb 26, 2025
@spypsy
chore!: enable multiple L1 nodes to be used (#11945)
fcf6278 
- Updates `ETHEREUM_HOST` env var to `ETHEREUM_HOSTS`. Using a single
host should still work as it did before
- Single `ViemWalletClient` & `ViemPublicClient`

BREAKING CHANGE:
- env var `ETHEREUM_HOST` -> `ETHEREUM_HOSTS`
- CLI arg `--l1-rpc-url` -> `--l1-rpc-urls`
- TypeScript configs with `l1RpcUrl` -> `l1RpcUrls`
- aztec.js functions with `l1RpcUrl` -> `l1RpcUrls`
- `DeployL1Contracts` (type) -> `DeployL1ContractsReturnType`

Fixes #11790 

Follow-up #12254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spypsy