Skip to content

Commit

Permalink
init
Browse files Browse the repository at this point in the history
  • Loading branch information
sklppy88 committed Jan 22, 2025
1 parent 90f5e8f commit cdbeb30
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,7 @@ unconstrained fn transfer_to_private_external_orchestration() {
&mut env.public(),
);

// We need to manually add the note because #8771 has not yet been implemented
utils::add_token_note(
env,
token_contract_address,
recipient,
amount,
note_randomness,
);
env.advance_block_by(1);

// Recipient's private balance should be equal to the amount
utils::check_private_balance(token_contract_address, recipient, amount);
Expand Down
3 changes: 2 additions & 1 deletion yarn-project/simulator/src/public/fixtures/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ export function createTxForPublicCalls(
appExecutionRequests: PublicExecutionRequest[],
teardownExecutionRequest?: PublicExecutionRequest,
gasUsedByPrivate: Gas = Gas.empty(),
firstNullifier: Fr = Fr.random(),
): Tx {
assert(
setupExecutionRequests.length > 0 || appExecutionRequests.length > 0 || teardownExecutionRequest !== undefined,
Expand All @@ -172,7 +173,7 @@ export function createTxForPublicCalls(

const forPublic = PartialPrivateTailPublicInputsForPublic.empty();
// TODO(#9269): Remove this fake nullifier method as we move away from 1st nullifier as hash.
forPublic.nonRevertibleAccumulatedData.nullifiers[0] = Fr.random(); // fake tx nullifier
forPublic.nonRevertibleAccumulatedData.nullifiers[0] = firstNullifier; // fake tx nullifier

// We reverse order because the simulator expects it to be like a "stack" of calls to pop from
for (let i = setupCallRequests.length - 1; i >= 0; i--) {
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/telemetry-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@
"../../foundation/src/jest/setup.mjs"
]
}
}
}
16 changes: 13 additions & 3 deletions yarn-project/txe/src/oracle/txe_oracle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -827,11 +827,19 @@ export class TXE implements TypedOracle {
/*appExecutionRequests=*/ isTeardown ? [] : [executionRequest],
/*teardownExecutionRequests=*/ isTeardown ? executionRequest : undefined,
gasUsedByPrivate,
this.getTxRequestHash(),
);

const result = await simulator.simulate(tx);
const noteHashes = result.avmProvingRequest.inputs.output.accumulatedData.noteHashes.filter(s => !s.isEmpty());

this.addPublicLogs(result.avmProvingRequest.inputs.publicInputs.publicLogs);
await this.addUniqueNoteHashesFromPublic(noteHashes);

this.addPublicLogs(
result.avmProvingRequest.inputs.output.accumulatedData.publicLogs.filter(
log => !log.contractAddress.equals(AztecAddress.ZERO),
),
);

return Promise.resolve(result);
}
Expand Down Expand Up @@ -883,7 +891,7 @@ export class TXE implements TypedOracle {
const sideEffects = executionResult.avmProvingRequest.inputs.output.accumulatedData;
const publicDataWrites = sideEffects.publicDataWrites.filter(s => !s.isEmpty());
const noteHashes = sideEffects.noteHashes.filter(s => !s.isEmpty());
const nullifiers = sideEffects.nullifiers.filter(s => !s.isEmpty());
const nullifiers = sideEffects.nullifiers.filter(s => !s.isEmpty()).filter(s => !s.equals(this.getTxRequestHash()));
await this.addPublicDataWrites(publicDataWrites);
await this.addUniqueNoteHashesFromPublic(noteHashes);
await this.addSiloedNullifiers(nullifiers);
Expand Down Expand Up @@ -997,7 +1005,9 @@ export class TXE implements TypedOracle {
const sideEffects = executionResult.avmProvingRequest.inputs.output.accumulatedData;
const publicDataWrites = sideEffects.publicDataWrites.filter(s => !s.isEmpty());
const noteHashes = sideEffects.noteHashes.filter(s => !s.isEmpty());
const nullifiers = sideEffects.nullifiers.filter(s => !s.isEmpty());
const nullifiers = sideEffects.nullifiers
.filter(s => !s.isEmpty())
.filter(s => !s.equals(this.getTxRequestHash()));
await this.addPublicDataWrites(publicDataWrites);
await this.addUniqueNoteHashes(noteHashes);
await this.addSiloedNullifiers(nullifiers);
Expand Down

0 comments on commit cdbeb30

Please sign in to comment.