[1 changes] chore: bump external pinned commits (noir-lang/noir#7515)

feat: let all compiler errors carry a Location instead of a Span (noir-lang/noir#7486) chore: Increaes base64's allotted time (noir-lang/noir#7521) fix: don't crash on broken impl syntax (noir-lang/noir#7512) feat: optimize out range checks on limiting cases (noir-lang/noir#7510) chore: clippy fixes (noir-lang/noir#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (noir-lang/noir#7508) feat(debugger): REPL add breakpoint by sourcecode line (noir-lang/noir#5204) fix: issue duplicate error on impl function without self (noir-lang/noir#7490) feat(experimental): Support struct constructors in match patterns (noir-lang/noir#7489) feat: use resolved type instead of needing Constructor.struct_type (noir-lang/noir#7500) feat: better error message when keyword is found instead of type in p… (noir-lang/noir#7501) chore: bump external pinned commits (noir-lang/noir#7497) feat(experimental): Add invalid pattern syntax error (noir-lang/noir#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (noir-lang/noir#7491) fix(experimental): Allow shadowing in match patterns (noir-lang/noir#7484) chore: regression test #7195 (noir-lang/noir#7233) chore(docs): Section on `noir-profiler execution-opcodes` (noir-lang/noir#7480) chore: improve proptesting of 128bit values in `noirc_abi` (noir-lang/noir#7485) chore(profiler): Use brillig names for outputted flamegraphs (noir-lang/noir#7470) chore(docs): Profiler images reference (noir-lang/noir#7481) fix: don't use dummy location when inserting debug code (noir-lang/noir#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (noir-lang/noir#7449)
AztecProtocol · Feb 26, 2025 · 9646851 · 9646851
1 parent f7a65ee
commit 9646851
Show file tree

Hide file tree

Showing 413 changed files with 21,998 additions and 4,423 deletions.
diff --git a/.noir-sync-commit b/.noir-sync-commit
@@ -1 +1 @@
-fdfe2bf752771b9611dc71953d50423b4ae7ec44
+f0c1c7ba3feaaa28905bb0813d14acc6673ca797
diff --git a/noir/noir-repo/.github/benchmark_projects.yml b/noir/noir-repo/.github/benchmark_projects.yml
@@ -1,4 +1,4 @@
-define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
+define: &AZ_COMMIT 17e79f42c0a1895dc87a74e4155591e38c45f09b
 projects:
   private-kernel-inner:
     repo: AztecProtocol/aztec-packages
@@ -18,7 +18,7 @@ projects:
     compilation-timeout: 1.2
     execution-timeout: 0.02
     compilation-memory-limit: 250
-    execution-memory-limit: 200
+    execution-memory-limit: 210
   private-kernel-reset:
     repo: AztecProtocol/aztec-packages
     ref: *AZ_COMMIT
@@ -66,7 +66,7 @@ projects:
     num_runs: 1
     timeout: 60
     compilation-timeout: 100
-    compilation-memory-limit: 7000
+    compilation-memory-limit: 8000
   rollup-block-root:
     repo: AztecProtocol/aztec-packages
     ref: *AZ_COMMIT
@@ -75,7 +75,7 @@ projects:
     timeout: 60
     compilation-timeout: 110
     execution-timeout: 40
-    compilation-memory-limit: 7000
+    compilation-memory-limit: 8000
     execution-memory-limit: 1500
   rollup-merge:
     repo: AztecProtocol/aztec-packages

diff --git a/noir/noir-repo/.github/workflows/bump-aztec-packages-commit.yml b/noir/noir-repo/.github/workflows/bump-aztec-packages-commit.yml
@@ -0,0 +1,50 @@
+name: Bump external repos pinned commits
+
+on:
+  workflow_dispatch:
+  schedule:
+    # Trigger at 8am on Mondays
+    - cron: '0 8 * * 1'
+
+
+jobs:
+  bump-commit:
+    name: Update external repo pinned commits
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+        with:
+          ref: master
+
+      - name: Check for existing PR
+        id: pr-check
+        run: |
+          set -xue # print commands         
+          PR_URL=$(gh pr list --repo noir-lang/noir --head bump-aztec-packages --json url --jq ".[0].url")
+          echo "pr_url=$PR_URL" >> $GITHUB_OUTPUT
+        env:
+          GH_TOKEN: ${{ github.token }}
+
+      - name: Configure git
+        run: |
+          git config user.name noirwhal
+          git config user.email tomfrench@aztecprotocol.com    
+        
+      - name: Update commit
+        run: |
+          git checkout bump-aztec-packages || git checkout -b bump-aztec-packages
+          ./scripts/bump-aztec-packages-commit.sh
+          git add .
+          git commit -m 'chore: Update pinned commit of aztec-packages'
+          git push --set-upstream origin bump-aztec-packages --force
+
+      - name: Create PR
+        if: ${{ steps.pr-check.outputs.pr_url == '' }}
+        run: |
+          PR_BODY="""
+          Automated update of the pinned commit of [aztec-packages](https://github.com/AztecProtocol/aztec-packages) repository against which we run benchmarks.
+          """
+          gh pr create --repo noir-lang/noir --title "chore: bump external pinned commits" --body "$PR_BODY" --base master --head bump-aztec-packages
+        env:
+          GH_TOKEN: ${{ secrets.NOIR_REPO_TOKEN }}
diff --git a/noir/noir-repo/.github/workflows/publish-nargo.yml b/noir/noir-repo/.github/workflows/publish-nargo.yml
@@ -59,21 +59,28 @@ jobs:
       - name: Build environment and Compile
         run: |
           cargo build --package nargo_cli --release --target ${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
-
+          cargo build --package noir_profiler --release --target ${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
+          cargo build --package noir_inspector --release --target ${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
+      
       - name: Package artifacts
         run: |
           mkdir dist
           cp ./target/${{ matrix.target }}/release/nargo ./dist/nargo
-          7z a -ttar -so -an ./dist/* | 7z a -si ./nargo-${{ matrix.target }}.tar.gz
+          cp ./target/${{ matrix.target }}/release/noir-profiler ./dist/noir-profiler
+          cp ./target/${{ matrix.target }}/release/noir-inspector ./dist/noir-inspector
+
+          # TODO(https://github.com/noir-lang/noir/issues/7445): Remove the separate nargo binary
+          7z a -ttar -so -an ./dist/nargo | 7z a -si ./nargo-${{ matrix.target }}.tar.gz
+          7z a -ttar -so -an ./dist/* | 7z a -si ./noir-${{ matrix.target }}.tar.gz
 
-      - name: Upload artifact
+      - name: Upload Noir binaries artifact
         uses: actions/upload-artifact@v4
         with:
-          name: nargo-${{ matrix.target }}
+          name: noir-${{ matrix.target }}
           path: ./dist/*
           retention-days: 3
 
-      - name: Upload binaries to release tag
+      - name: Upload nargo binary to release tag
         uses: svenstaro/upload-release-action@v2
         if: ${{ inputs.publish || github.event_name == 'schedule' }}
         with:
@@ -84,12 +91,23 @@ jobs:
           overwrite: true
           tag: ${{ inputs.tag || 'nightly' }} # This will fail if `inputs.tag` is not a tag (e.g. testing a branch)
 
+      - name: Upload Noir binaries to release tag
+        uses: svenstaro/upload-release-action@v2
+        if: ${{ inputs.publish || github.event_name == 'schedule' }}
+        with:
+          repo_name: noir-lang/noir
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ./noir-${{ matrix.target }}.tar.gz
+          asset_name: noir-${{ matrix.target }}.tar.gz
+          overwrite: true
+          tag: ${{ inputs.tag || 'nightly' }} # This will fail if `inputs.tag` is not a tag (e.g. testing a branch)
+
       - name: Get formatted date
         id: date
         if: ${{ inputs.tag == '' && inputs.publish || github.event_name == 'schedule' }}
         run: echo "date=$(date '+%Y-%m-%d')" >> $GITHUB_OUTPUT
 
-      - name: Upload binaries to release with date tag
+      - name: Upload nargo binary to release with date tag
         uses: svenstaro/upload-release-action@v2
         if: ${{ inputs.tag == '' && inputs.publish || github.event_name == 'schedule' }}
         with:
@@ -102,6 +120,19 @@ jobs:
           overwrite: true
           tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }}
 
+      - name: Upload Noir binaries to release with date tag
+        uses: svenstaro/upload-release-action@v2
+        if: ${{ inputs.tag == '' && inputs.publish || github.event_name == 'schedule' }}
+        with:
+          repo_name: noir-lang/noir
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ./noir-${{ matrix.target }}.tar.gz
+          asset_name: noir-${{ matrix.target }}.tar.gz
+          prerelease: true
+          make_latest: false
+          overwrite: true
+          tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }}
+
   build-linux:
     runs-on: ubuntu-22.04
     env:
@@ -135,23 +166,31 @@ jobs:
         with:
           tool: cross@0.2.5
 
-      - name: Build Nargo
-        run: cross build --package nargo_cli --release --target=${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
+      - name: Build binaries
+        run: |
+          cross build --package nargo_cli --release --target=${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
+          cross build --package noir_profiler --release --target=${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
+          cross build --package noir_inspector --release --target ${{ matrix.target }} --no-default-features --features "${{ inputs.features }}"
 
       - name: Package artifacts
         run: |
           mkdir dist
           cp ./target/${{ matrix.target }}/release/nargo ./dist/nargo
-          7z a -ttar -so -an ./dist/* | 7z a -si ./nargo-${{ matrix.target }}.tar.gz
+          cp ./target/${{ matrix.target }}/release/noir-profiler ./dist/noir-profiler
+          cp ./target/${{ matrix.target }}/release/noir-inspector ./dist/noir-inspector
 
-      - name: Upload artifact
+          # TODO(https://github.com/noir-lang/noir/issues/7445): Remove the separate nargo binary
+          tar -czf nargo-${{ matrix.target }}.tar.gz -C dist nargo
+          tar -czf noir-${{ matrix.target }}.tar.gz -C dist .
+
+      - name: Upload Noir binaries artifact
         uses: actions/upload-artifact@v4
         with:
-          name: nargo-${{ matrix.target }}
+          name: noir-${{ matrix.target }}
           path: ./dist/*
           retention-days: 3
 
-      - name: Upload binaries to release tag
+      - name: Upload nargo binary to release tag
         uses: svenstaro/upload-release-action@v2
         if: ${{ inputs.publish }}
         with:
@@ -163,12 +202,24 @@ jobs:
           overwrite: true
           tag: ${{ inputs.tag || 'nightly' }} # This will fail if `inputs.tag` is not a tag (e.g. testing a branch)
 
+      - name: Upload Noir binaries to release tag
+        uses: svenstaro/upload-release-action@v2
+        if: ${{ inputs.publish }}
+        with:
+          repo_name: noir-lang/noir
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ./noir-${{ matrix.target }}.tar.gz
+          asset_name: noir-${{ matrix.target }}.tar.gz
+          prerelease: true
+          overwrite: true
+          tag: ${{ inputs.tag || 'nightly' }} # This will fail if `inputs.tag` is not a tag (e.g. testing a branch)
+
       - name: Get formatted date
         id: date
         if: ${{ env.NIGHTLY_RELEASE && inputs.publish }}
         run: echo "date=$(date '+%Y-%m-%d')" >> $GITHUB_OUTPUT
 
-      - name: Upload binaries to release with date tag
+      - name: Upload nargo binary to release with date tag
         uses: svenstaro/upload-release-action@v2
         if: ${{ env.NIGHTLY_RELEASE && inputs.publish }}
         with:
@@ -181,4 +232,17 @@ jobs:
           overwrite: true
           tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }}
 
+      - name: Upload Noir binaries to release with date tag
+        uses: svenstaro/upload-release-action@v2
+        if: ${{ env.NIGHTLY_RELEASE && inputs.publish }}
+        with:
+          repo_name: noir-lang/noir
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ./noir-${{ matrix.target }}.tar.gz
+          asset_name: noir-${{ matrix.target }}.tar.gz
+          prerelease: true
+          make_latest: false
+          overwrite: true
+          tag: ${{ format('{0}-{1}', 'nightly', steps.date.outputs.date) }}
+
 
diff --git a/noir/noir-repo/.github/workflows/reports.yml b/noir/noir-repo/.github/workflows/reports.yml
@@ -305,7 +305,7 @@ jobs:
           repository: ${{ matrix.repo }}
           path: test-repo
           ref: ${{ matrix.ref }}
-
+      
       - name: Fetch noir dependencies
         working-directory: ./test-repo/${{ matrix.path }}
         run: |
@@ -341,7 +341,7 @@ jobs:
           path: ${{ steps.compilation_report.outputs.report_path }}
           retention-days: 3
           overwrite: true
-
+        
       - name: Generate execution report
         id: execution_report
         working-directory: ./test-repo/${{ matrix.path }}
@@ -359,7 +359,7 @@ jobs:
 
           echo "report_name=$REPORT_NAME" >> $GITHUB_OUTPUT
           echo "report_path=$REPORT_PATH" >> $GITHUB_OUTPUT
-
+    
       - name: Upload execution report
         if: ${{ !matrix.cannot_execute }}
         uses: actions/upload-artifact@v4
@@ -417,9 +417,6 @@ jobs:
       - name: Download nargo binary
         uses: ./scripts/.github/actions/download-nargo
 
-      - name: Download nargo binary
-        uses: ./scripts/.github/actions/download-nargo
-
       - name: Checkout
         uses: actions/checkout@v4
         with:
@@ -719,7 +716,7 @@ jobs:
       - upload_compilation_memory_report
       - upload_execution_report
       - upload_execution_memory_report
-
+     
     steps:
         - name: Report overall success
           run: |

diff --git a/noir/noir-repo/.github/workflows/test-js-packages.yml b/noir/noir-repo/.github/workflows/test-js-packages.yml
@@ -493,7 +493,7 @@ jobs:
       fail-fast: false
       matrix:
         include: ${{ fromJson( needs.critical-library-list.outputs.libraries )}}
-
+         
     name: Check external repo - ${{ matrix.repo }}/${{ matrix.path }}
     steps:
       - name: Checkout

diff --git a/noir/noir-repo/.gitignore b/noir/noir-repo/.gitignore
@@ -52,4 +52,7 @@ tooling/noir_js/lib
 # docs autogen build
 /docs/docs/noir_js/reference/
 
-codegen
+codegen
+
+**/cspell.json
+!./cspell.json
diff --git a/noir/noir-repo/.release-please-manifest.json b/noir/noir-repo/.release-please-manifest.json
@@ -1,3 +1,3 @@
 {
-  ".": "1.0.0-beta.2"
+  ".": "1.0.0-beta.3"
 }
diff --git a/noir/noir-repo/.vscode/settings.json b/noir/noir-repo/.vscode/settings.json
@@ -8,5 +8,11 @@
     "[javascript]": {
         "editor.defaultFormatter": "esbenp.prettier-vscode"
     },
+    "[markdown]": {
+        "files.trimTrailingWhitespace": true
+    },
+    "[yaml]": {
+        "files.trimTrailingWhitespace": true
+    },
     "rust-analyzer.server.extraEnv": { "RUSTUP_TOOLCHAIN": "stable" }
 }
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		fdfe2bf752771b9611dc71953d50423b4ae7ec44
		f0c1c7ba3feaaa28905bb0813d14acc6673ca797