Skip to content

Commit

Permalink
chore: Exclude system metrics from k8s deployments (#11401)
Browse files Browse the repository at this point in the history
These are automatically collected behind the scenes, no need to
re-publish them.
  • Loading branch information
spalladino authored Jan 21, 2025
1 parent 1e5d225 commit 31be5fb
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 17 deletions.
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/boot-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.bootNode.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- containerPort: {{ .Values.bootNode.service.nodePort }}
- containerPort: {{ .Values.bootNode.service.p2pTcpPort }}
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/faucet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.faucet.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- name: http
containerPort: {{ .Values.faucet.service.nodePort }}
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/prover-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.proverAgent.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
resources:
{{- toYaml .Values.proverAgent.resources | nindent 12 }}
{{- end }}
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/prover-broker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.proverBroker.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
resources:
{{- toYaml .Values.proverBroker.resources | nindent 12 }}
volumes:
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/prover-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.proverNode.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- containerPort: {{ .Values.proverNode.service.nodePort }}
- containerPort: {{ .Values.proverNode.service.p2pTcpPort }}
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/pxe.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.pxe.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- name: http
containerPort: {{ .Values.pxe.service.nodePort }}
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/transaction-bot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.bot.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- name: http
containerPort: {{ .Values.bot.service.nodePort }}
Expand Down
2 changes: 1 addition & 1 deletion spartan/aztec-network/templates/validator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ spec:
- name: USE_GCLOUD_OBSERVABILITY
value: "{{ .Values.telemetry.useGcloudObservability }}"
- name: OTEL_EXCLUDE_METRICS
value: "{{ .Values.validator.otelExcludeMetrics }}"
value: "{{ .Values.telemetry.excludeMetrics }}"
ports:
- containerPort: {{ .Values.validator.service.nodePort }}
- containerPort: {{ .Values.validator.service.p2pTcpPort }}
Expand Down
10 changes: 1 addition & 9 deletions spartan/aztec-network/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ telemetry:
enabled: false
otelCollectorEndpoint:
useGcloudObservability: false
excludeMetrics: "system"

images:
aztec:
Expand Down Expand Up @@ -88,7 +89,6 @@ bootNode:
stakingAssetAddress: ""
storageSize: "1Gi"
dataDir: "/data"
otelExcludeMetrics: ""

validator:
# If true, the validator will use its peers to serve as the boot node.
Expand Down Expand Up @@ -134,7 +134,6 @@ validator:
dataDir: "/data"
l1FixedPriorityFeePerGas: ""
l1GasLimitBufferPercentage: ""
otelExcludeMetrics: ""

proverNode:
proverPublisherPrivateKey: "0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80"
Expand Down Expand Up @@ -171,7 +170,6 @@ proverNode:
intervalMs: 1000
maxParallelRequests: 100
failedProofStore: "gs://aztec-develop/spartan/failed-proofs"
otelExcludeMetrics: ""

pxe:
logLevel: "debug; info: aztec:simulator, json-rpc"
Expand All @@ -188,7 +186,6 @@ pxe:
requests:
memory: "4Gi"
cpu: "1"
otelExcludeMetrics: ""

bot:
enabled: true
Expand Down Expand Up @@ -218,7 +215,6 @@ bot:
requests:
memory: "4Gi"
cpu: "1"
otelExcludeMetrics: ""

ethereum:
replicas: 1
Expand Down Expand Up @@ -271,7 +267,6 @@ ethereum:
cpu: "1"
storageSize: "80Gi"
deployL1ContractsPrivateKey:
otelExcludeMetrics: ""

proverAgent:
service:
Expand All @@ -290,7 +285,6 @@ proverAgent:
memory: "4Gi"
cpu: "1"
pollInterval: 200
otelExcludeMetrics: ""

proverBroker:
service:
Expand All @@ -308,7 +302,6 @@ proverBroker:
memory: "4Gi"
cpu: "1"
maxOldSpaceSize: "3584"
otelExcludeMetrics: ""

jobs:
deployL1Verifier:
Expand All @@ -326,4 +319,3 @@ faucet:
requests:
memory: "2Gi"
cpu: "200m"
otelExcludeMetrics: ""

0 comments on commit 31be5fb

Please sign in to comment.