Skip to content

Commit

Permalink
typos and linking issues
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan committed Jan 6, 2025
1 parent bfe1942 commit 2b6fb69
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 7 deletions.
1 change: 1 addition & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"auditability",
"authwit",
"authwits",
"authwitness",
"Automine",
"autonat",
"autorun",
Expand Down
2 changes: 1 addition & 1 deletion noir-projects/aztec-nr/aztec/src/keys/secret_derivation.nr
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pub fn derive_aes_secret(secret: Scalar, point: Point) -> [u8; 32] {
}

shared_secret_bytes_with_separator[32] = GENERATOR_INDEX__SYMMETRIC_KEY;

// TODO(https://github.com/AztecProtocol/aztec-packages/issues/10537): Replace use of sha256
sha256(shared_secret_bytes_with_separator)
}

Expand Down
4 changes: 2 additions & 2 deletions noir-projects/aztec-nr/aztec/src/macros/notes/mod.nr
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ comptime fn generate_setup_payload(
+ 2 /* log_plaintext_length */
+ 14 /* AES padding */;
// Each field contains 31 bytes so the length in fields is computed as ceil(encrypted_log_byte_length / 31)
// --> we achieve rouding by adding 30 and then dividing without remainder
// --> we achieve rounding by adding 30 and then dividing without remainder
let encrypted_log_field_length = (encrypted_log_byte_length + 30) / 31;

(
Expand Down Expand Up @@ -661,7 +661,7 @@ comptime fn generate_finalization_payload(
+ 2 /* log_plaintext_length */
+ 14 /* AES padding */;
// Each field contains 31 bytes so the length in fields is computed as ceil(setup_log_byte_length / 31)
// --> we achieve rouding by adding 30 and then dividing without remainder
// --> we achieve rounding by adding 30 and then dividing without remainder
let setup_log_field_length = (setup_log_byte_length + 30) / 31;
let public_values_field_length = public_values_length * 32;
let finalization_log_byte_length =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ contract AMM {
let sender = context.msg_sender();

// Liquidity tokens are burned when liquidity is removed in order to reduce the total supply. However, we lack
// a function to privately burn, so we instead transfer the tokens into the AMM's public balance, and them have
// a function to privately burn, so we instead transfer the tokens into the AMM's public balance, and then have
// the AMM publicly burn its own tokens.
// TODO(#10287): consider adding a private burn
liquidity_token.transfer_to_public(sender, context.this_address(), liquidity, nonce).call(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ contract TokenBridge {
/// Claims the bridged tokens and makes them accessible in private. Note that recipient's address is not revealed
/// but the amount is. Hence it's most likely possible to determine to which L1 deposit this claim corresponds to
/// (unless there are multiple pending deposits of the same amount).
/// TODO(#8416): Consider creating a truly private claim flow.
#[private]
fn claim_private(
recipient: AztecAddress, // recipient of the bridged tokens
Expand Down
3 changes: 2 additions & 1 deletion noir-projects/noir-protocol-circuits/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ Verifier.toml
target
crates/autogenerated
/Nargo.toml
/private_kernel_reset_dimensions.json
/private_kernel_reset_dimensions.json
install-state.gz
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface ContractInstance {
contractClassId: Fr;
/** Hash of the selector and arguments to the constructor. */
initializationHash: Fr;
/** Public keys associated with this intsance. */
/** Public keys associated with this instance. */
publicKeys: PublicKeys;
}

Expand Down
1 change: 1 addition & 0 deletions yarn-project/foundation/src/fields/point.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { Fr } from './fields.js';
* Represents a Point on an elliptic curve with x and y coordinates.
* The Point class provides methods for creating instances from different input types,
* converting instances to various output formats, and checking the equality of points.
* TODO(#7386): Clean up this class.
*/
export class Point {
static ZERO = new Point(Fr.ZERO, Fr.ZERO, false);
Expand Down

0 comments on commit 2b6fb69

Please sign in to comment.