Skip to content

Commit

Permalink
9745: Addressing review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanmon committed Nov 12, 2024
1 parent 713ef29 commit 28c426e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion barretenberg/cpp/pil/avm/main.pil
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ namespace main(256);
//===== Memory Slice Constraints ============================================
pol commit sel_slice_gadget; // Selector to activate a slice gadget operation in the gadget (#[PERM_MAIN_SLICE]).

// Activate only if tag_err is disabled or retsize (ib) is non-zero
// Activate only if op_err is disabled or retsize (ib) is non-zero
ib * (1 - op_err) * (sel_op_calldata_copy + sel_op_external_return - sel_slice_gadget)= 0;

//====== Inter-table Constraints ============================================
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1438,6 +1438,7 @@ AvmError AvmTraceBuilder::op_get_env_var(uint8_t indirect, uint8_t env_var, uint
op_dagasleft(indirect, dst_offset);
break;
default:
// Cannot happen thanks to the first if clause. This is to make the compiler happy.
throw std::runtime_error("Invalid environment variable");
break;
}
Expand Down Expand Up @@ -2548,7 +2549,6 @@ AvmError AvmTraceBuilder::op_nullifier_exists(uint8_t indirect,
{
auto const clk = static_cast<uint32_t>(main_trace.size()) + 1;

// TODO: resolved_address should be used
auto [resolved_nullifier_offset, resolved_address, resolved_dest] =
Addressing<3>::fromWire(indirect, call_ptr)
.resolve({ nullifier_offset, address_offset, dest_offset }, mem_trace_builder);
Expand Down

0 comments on commit 28c426e

Please sign in to comment.