Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan authored Oct 25, 2024
1 parent 443c885 commit 07072c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions noir-projects/aztec-nr/aztec/src/encrypted_logs/payload.nr
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ fn compute_private_log_payload<let P: u32, let M: u32>(
}

// Current unoptimized size of the encrypted log
// empty_prefix (prefix_length bytes)
// empty_prefix (1 byte)
// incoming_tag (32 bytes)
// outgoing_tag (32 bytes)
// eph_pk (32 bytes)
Expand All @@ -95,7 +95,7 @@ fn fr_to_fq(r: Field) -> Scalar {
}

fn generate_ephemeral_key_pair() -> (Scalar, Point) {
// @todo Need to draw randomness from the full domain of Fq not only Fr
offset += 48 * 2;
// We use the randomness to preserve the privacy of both the sender and recipient via encryption, so a malicious
// sender could use non-random values to reveal the plaintext. But they already know it themselves anyway, and so
// the recipient already trusts them to not disclose this information. We can therefore assume that the sender will
Expand Down
2 changes: 1 addition & 1 deletion noir-projects/aztec-nr/aztec/src/macros/notes/mod.nr
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ comptime fn generate_finalization_payload(
// We load the setup log from storage
let setup_log_fields: [Field; $setup_log_field_length] = self.context.storage_read(self.setup_log_slot);

// We convert the lof from fields to bytes
// We convert the log from fields to bytes
let setup_log: [u8; $setup_log_byte_length] = aztec::utils::bytes::fields_to_bytes(setup_log_fields);

// First byte should be zero as the number of public values is populated in public
Expand Down

0 comments on commit 07072c9

Please sign in to comment.