Skip to content

Commit

Permalink
feat: Cycle Group Fuzzer (#12154)
Browse files Browse the repository at this point in the history
This pr introduces a fuzzer for `stdlib::primitives::cycle_group`
  • Loading branch information
Sarkoxed authored Feb 27, 2025
1 parent a301f72 commit 061189d
Show file tree
Hide file tree
Showing 3 changed files with 1,703 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ cycle_group<Builder> cycle_group<Builder>::dbl(const std::optional<AffineElement

context->create_ecc_dbl_gate(bb::ecc_dbl_gate_<FF>{
.x1 = x.get_witness_index(),
.y1 = modified_y.normalize().get_witness_index(),
.y1 = modified_y.get_normalized_witness_index(),
.x3 = result.x.get_witness_index(),
.y3 = result.y.get_witness_index(),
});
Expand Down Expand Up @@ -981,7 +981,7 @@ cycle_group<Builder>::straus_scalar_slice::straus_scalar_slice(Builder* context,

if constexpr (IS_ULTRA) {
const auto slice_indices =
context->decompose_into_default_range(scalar.normalize().get_witness_index(),
context->decompose_into_default_range(scalar.get_normalized_witness_index(),
num_bits,
table_bits,
"straus_scalar_slice decompose_into_default_range");
Expand Down
Loading

1 comment on commit 061189d

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'P2P Testbench'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 061189d Previous: a301f72 Ratio
degree-1-strict - maxDelay 1457 ms 946 ms 1.54
degree-1-strict - averageDelay 721.25 ms 414.75 ms 1.74
degree-1-strict - medianDelay 722 ms 352 ms 2.05
normal-degree-50-nodes - medianDelay 1121 ms 955 ms 1.17

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Maddiaa0

Please sign in to comment.