allow custom ssl options #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this, the only thing I would say is instead of |
|
Thanks @Azolo. Yes, absolutely makes sense! i've changed names and pushed an update. |
Azolo
requested changes
Sep 18, 2018
test/websockex/conn_test.exs
Outdated
|
|
||
| test "open_socket with custom ssl options", context do | ||
| ssl_options = [cacertfile: Path.join([__DIR__, "..", "support", "priv", "websockexca.cer"])] | ||
| conn = WebSockex.Conn.new(context.uri, ssl: ssl_options) |
There was a problem hiding this comment.
This doesn't match what you have in your example. 😣
There was a problem hiding this comment.
Bah .. not only didn't it match the example .. the entire change was missing. no idea how i missed it, sorry for the noise. i've pushed an update.
for a connection which uses client certificates, that would be for example:
```
{:ok, _} = WebSockex.start_link(
WebSockex.Conn.new(
"wss://host/path",
ssl_options: [
cacertfile: "/certificates/ca.pem",
certfile: "/certificates/cert.pem",
keyfile: "/certificates/key.pem"
]
),
__MODULE__,
:fake_state
)
```
|
@Azolo anything else or are we good to go with this? |
Azolo
approved these changes
Sep 24, 2018
|
thanks a lot! |
|
@steffkes Thanks for the ping, been super busy and totally forget. |
|
no worries, i guess every maintainer knows that situation pretty well. a gentle reminder goes a long way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR contains the simple change which i've mentioned over at #33. for a connection which uses client certificates, that would be for example: