Migrate unfeasibility explanation #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 30, 2019
spec/lib/migrations/spending_proposals/budget_investments_spec.rb
Outdated
Show resolved
Hide resolved
| require "rails_helper" | ||
| require "migrations/spending_proposal/budget_investments" | ||
|
|
||
| describe Migrations::SpendingProposal::BudgetInvestments do |
There was a problem hiding this comment.
RSpec/FilePath: Spec path should end with migrations/spending_proposal/budget_investments*_spec.rb. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath)
There was a problem hiding this comment.
Thank you Hound 😌 We'll fix this in a separate PR 👌
| require "rails_helper" | ||
| require "migrations/spending_proposal/budget_investment" | ||
|
|
||
| describe Migrations::SpendingProposal::BudgetInvestment do |
There was a problem hiding this comment.
RSpec/FilePath: Spec path should end with migrations/spending_proposal/budget_investment*_spec.rb. (http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath)
There was a problem hiding this comment.
Thank you Hound 😌 We'll fix this in a separate PR 👌
decabeza
approved these changes
Jan 30, 2019
We already have budget investment for every corresponding spending proposal. However this attribute was not migrated correctly, creating a validation error when trying to update these budget investments. With this commit all budget investmetns should be valid and we can continue working on migration supports and ballots.
ab60c4d to
12b8ffd
Compare
microweb10
approved these changes
Jan 30, 2019
Mainly for development
There are some spending proposals that use either the price_explanation or the internal_comments to explain why a spending proposal is unfeasible. We must use these attributes to fill in the unfeasible_explanation of a budget investment, otherwise they would still have a validation error.
houndci-bot
reviewed
Jan 30, 2019
| migration.update | ||
|
|
||
| budget_investment.reload | ||
| expect(budget_investment.unfeasibility_explanation).to eq("price explanation saying it is too expensive") |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [111/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
javierm
approved these changes
Feb 6, 2019
voodoorai2000
added a commit
that referenced
this pull request
Feb 7, 2019
We now have a dependency on this spec, added in a previous PR[1]. This is due the spec indirectly creating a Comment object[1] that requires the spending proposal to have an administrator. We could separate the rake task to deal with the initial PR requirements and this PR's requirements. But we should put it all in a single rake task when everything is ready. So just fixing the spec for now. [1] #1853
voodoorai2000
added a commit
that referenced
this pull request
Mar 5, 2019
We now have a dependency on this spec, added in a previous PR[1]. This is due the spec indirectly creating a Comment object[1] that requires the spending proposal to have an administrator. We could separate the rake task to deal with the initial PR requirements and this PR's requirements. But we should put it all in a single rake task when everything is ready. So just fixing the spec for now. [1] #1853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We already have budget investment for every corresponding spending proposal.
However the
unfeasibility_explanationattribute was not migrated correctly. This raises a validation error when trying to update any other attribute in these budget investments.Objectives
Migrate this attribute for all relevant budget investments to make them valid so that we can continue working on migrating supports and ballots.
Does this PR need a Backport to CONSUL?
Yes, this will be important for the final migration
Notes
Adding some debug information in a method, to prevent the rake task from stopping early. If something is printed the ssh connection stays open.