Upstream #1540
Merged
Upstream #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select button seems to be outside the window. Removing some columns to make the select button visible by capybara This is just a temporary fix, we have to find a better solution. Playing with the css to find an appropriate length for the table containing this select button, is probably the way to go
…spec-helpers Split spec common actions support helper
Homepage design
…it through UI, after the notifications are created the test goes directly to the notifications page (after login in the user). To check if the notification icon is correctly shown, a new test has been created that only does that.
Regenerate Gemfile.lock
…haves-like-notifiable-in-app Flaky spec: Polls Concerns behaves like notifiable in-app Multiple users commented on my notifiable
Why: Heading filter where not being correctly displayed How: Increasing scenario to cover all possible combinations, and fixing the heading_filters method of the Valuation Budget Investment Controller to correctly: * Find how many investments the valuator can access * Count investments for each heading
Grouping scenarios makes it easier to follow the spec and to know where to put a new scenario
…ding_filters Fix valuation heading filters
Budget statuses
Added `:status_id` to valid params and new method to get all statuses defined for the budget.
Added relation with Status and set condition to validate milestone's description presence if there's no status set.
Investment milestone's project status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Update CONSUL and Madrid repos.
What include
This PR include: