Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1383

Merged
merged 12 commits into from
Mar 27, 2018
Merged

Minor fixes #1383

merged 12 commits into from
Mar 27, 2018

Conversation

decabeza
Copy link

Objectives

Minor fixes for i18n, HTML, and styles:

  • Improves i18n of admin budgets.
  • Adds class on backlink to admin budget investments show.
  • Moves h3 tag outside of table on polls results (Fixes HTML validation error).
  • Adds unicode_normalize for alt and title on image partial (Prevents HTML validation warning).
  • Adds map skip checkbox i18n for budget investments.
  • Adds a message on polls index if there are no open polls.
  • Adds a message on custom polls index if there are no open polls.
  • Fixes actions buttons on admin valuators index table.
  • Shows a message only if there are questions on legislation debate.
  • Updates custom meta tags for polls index.

Notes

Backport this PR to CONSUL except the custom commits:

  • Adds message on custom polls index if there are no open polls.
  • Updates custom meta tags for polls index.

@decabeza decabeza requested a review from bertocq March 22, 2018 11:17
@decabeza decabeza requested a review from voodoorai2000 March 26, 2018 06:51
@decabeza decabeza merged commit 5b6394d into master Mar 27, 2018
@decabeza decabeza deleted the minor-fixes branch March 27, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants