Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flaky spec: Poll Officing Officing dashboard available for multiple sessions #1368

Conversation

raul-fuentes
Copy link

References

Objectives

  • Fix the flaky, i seems to happen when the container of the selector for dni/passport isn't present. At first it looked like an error due the date used for the 2 poll_shift created (as it was here ) but a quick check using different dates provoked a different error, so suspicions recalled about a race condition in the selector container. The solution that I proposes here is just check the existence of the container using have_selector, which waits for js to be completed

Visual Changes (if any)

  • none

Notes

  • none

…xistence of the container is assured because have_conten waits for js to finish loading before checking
@bertocq
Copy link

bertocq commented Mar 19, 2018

Allright @raul-fuentes ! I'll do some travis rebuilds to be sure we're good. Nice and simple fix 👍

@bertocq bertocq merged commit d301622 into AyuntamientoMadrid:master Mar 21, 2018
@aitbw aitbw deleted the 1200_flaky_spec_poll_officing_officing_dashboard branch April 5, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants