Flaky spec: Residence Verify booth Unable to find visible css "#officing-booth" #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaCheca
reviewed
Mar 13, 2018
| booth = create(:poll_booth) | ||
| poll = create(:poll) | ||
|
|
||
| ba = create(:poll_booth_assignment, poll: poll, booth: booth) | ||
| oa = create(:poll_officer_assignment, officer: officer, booth_assignment: ba) | ||
| create(:poll_shift, officer: officer, booth: booth, date: Date.current) | ||
| oa = create(:poll_officer_assignment, |
There was a problem hiding this comment.
I think it's a good practice to name the variables as descriptive as possible...
There was a problem hiding this comment.
I changed the names to a more descriptive ones, and also changed the hardcoded '2018-01-01' date to a Date.current, because it's mocked before.
MariaCheca
reviewed
Mar 13, 2018
… a conflict when running tests at certain hours.
6eb442c to
b551535
Compare
MariaCheca
approved these changes
Mar 14, 2018
|
This code can't be backported, the related test not exists on consul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Explain why the test is flaky, or under which conditions/scenario it fails randomly
(The explanation is the same as in #1342, #1343 and #1349 PRs because the problem is exactly the same).
What happened here was that, at the moment the test tries to reach the residence verification page, the message that it's supposed to appear (announcing the booth choosen for that officer) is not there. In this case, because there is only one booth created, the test should not pass through the page to choose it (and it doesn't pass, in fact), so the booth should be choosen automatically. The problem is that the date of each officer assignment is different from Date.current, so, for the app, there aren't any booths for today and there is no message, what generates the test to fail.
I realized that the problem could be in the moment of creating the officer assignments. If they are created at 23:59:59 and the rest of the test is executed after 00:00:00, the dates for the objects and the
Date.current(used to check if there are any shifts today) won't be the same, because the shift will be for, lets say, 07/03/2018 and Date.current will be 08/03/2018.To prove that, I forced in the factory the dates of the
officer_assignmentsto an earlier date, and it failed in the exact same way as the reported ones.Explain why your PR fixes it
I stubbed the Date and Time clases to force them to give me a date I can controll. I set that date (01/01/2018) to the objects that depend on it. This way, it doesn't matter when the test is executed, for him it will always be the same date.
Visual Changes (if any)
There aren't, is a flaky.
Notes