Spendign Proposals migrator to Budget Investment #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoorai2000
approved these changes
Dec 14, 2017
Merged
voodoorai2000
added a commit
that referenced
this pull request
Jan 17, 2019
Create budget investment's votes for all corresponding spending proposal's votes. We already have budget investments for every spending proposal as of the partial migration done[1]. In method `create_budget_investment_vote` we are using 'yes' as the `vote` for consistency with the implementation in the `Investment`'s model[1]. With that acts_as_votable understands that it has to create a `vote_flag` of true before saving the vote to DB. [1] #1059 [2] https://github.com/AyuntamientoMadrid/consul/blob/master/app/models/budget/investment.rb#L296
voodoorai2000
added a commit
that referenced
this pull request
Feb 7, 2019
Create budget investment's votes for all corresponding spending proposal's votes. We already have budget investments for every spending proposal as of the partial migration done[1]. In method `create_budget_investment_vote` we are using 'yes' as the `vote` for consistency with the implementation in the `Investment`'s model[1]. With that acts_as_votable understands that it has to create a `vote_flag` of true before saving the vote to DB. [1] #1059 [2] https://github.com/AyuntamientoMadrid/consul/blob/master/app/models/budget/investment.rb#L296
voodoorai2000
added a commit
that referenced
this pull request
Mar 5, 2019
Create budget investment's votes for all corresponding spending proposal's votes. We already have budget investments for every spending proposal as of the partial migration done[1]. In method `create_budget_investment_vote` we are using 'yes' as the `vote` for consistency with the implementation in the `Investment`'s model[1]. With that acts_as_votable understands that it has to create a `vote_flag` of true before saving the vote to DB. [1] #1059 [2] https://github.com/AyuntamientoMadrid/consul/blob/master/app/models/budget/investment.rb#L296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just migrating stuff partially to get milestones working, we'll do it right at consul and completly here later on
Tested in pre! Use
bin/rake spending_proposals:migrate_to_budgets RAILS_ENV=productionwhen at pro