Improvements to grid based mining #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated approximate_direction() helper function in Utils script with a new approximation method, and renamed it to approximate_direction_4_ways() - Added approximate_direction_8_ways() function using the new approximation method - Updated and simplified update_player_pos() method in Minimap script, using the new utility function, and renamed it to update_player_tile_pos() - Updated and simplified determine_facing() method in Player script, using the new utility function
Just specifying that the type is Camera2D
- Moved the player's origin position to the centre of the player sprite, for better calculations later on. - Updated child nodes' positions - Updated animation properties - Player scent still needs to originate from the player's feet, so I added a get_feet_position() function for that
Made use of the new approximate_direction_8_ways() utility function and various other improvements, to make the grid-based mining system feel slightly more intuitive.
- Checks if the tile is "blocked" from the player. Eg: you can't mine diagonally if the tile has no free adjacent neighbours that are close to the player. - Cleaned up code for verifying other factors (is solid, is out of bounds etc). Also added a function for checking if a tile is solid.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.