Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication refresh #180

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Fix authentication refresh #180

merged 3 commits into from
Jul 23, 2022

Conversation

AvdLee
Copy link
Owner

@AvdLee AvdLee commented Jul 23, 2022

Fixes #137 by making use of the current date for all refreshes.

We were refreshing the token correctly once expired, but by using a fixed base date, we would still fail.

@AvdLee AvdLee self-assigned this Jul 23, 2022
@SwiftLeeBot
Copy link
Collaborator

Warnings
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'PricePoints' is deprecated: Deprecated
⚠️ 'PricePoints' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
Messages
📖

View more details on Bitrise

📖 AppStoreConnect-Swift-SDK-Tests: Executed 9 tests (0 failed, 0 retried, 0 skipped) in 0.109 seconds

SwiftLint found issues

Severity File Reason
Warning AppsListView.swift:48 Line should be 140 characters or less: currently 151 characters (line_length)
Warning AppsListView.swift:50 Line should be 140 characters or less: currently 151 characters (line_length)
Warning JWT.swift:41 Line should be 140 characters or less: currently 141 characters (line_length)
Warning JWT.swift:96 Line should be 140 characters or less: currently 143 characters (line_length)
Error JWT.swift:104 Line should be 160 characters or less: currently 163 characters (line_length)
Warning JWT.swift:113 Line should be 140 characters or less: currently 154 characters (line_length)

Code Coverage Report

Name Coverage

Generated by 🚫 Danger Swift against 1a66950

@AvdLee AvdLee merged commit c8d92cd into master Jul 23, 2022
@AvdLee AvdLee deleted the feature/update-documentation branch July 23, 2022 08:51
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.1.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIProvider fails to authorize requests 25 minutes after sending the first request
2 participants