Revert some subprocess.check_output

Avasam · Dec 24, 2024 · 1c491f7 · 1c491f7
1 parent 9676aa9
commit 1c491f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/stubs/gevent/@tests/stubtest_allowlist.txt b/stubs/gevent/@tests/stubtest_allowlist.txt
@@ -213,7 +213,6 @@ gevent.socket.wait_write
 # we have punted on ssl, the gevent version of these functions have an additional
 # argument for timeouts/blocking and there are some with different default values
 # for nbytes/length, for now we ignore that fact
-gevent.ssl.Purpose.__new__
 gevent.ssl.SSLSocket.__init__
 gevent.ssl.SSLSocket.do_handshake
 gevent.ssl.SSLSocket.read

diff --git a/tests/regr_test.py b/tests/regr_test.py
@@ -155,7 +155,9 @@ def setup_testcase_dir(package: DistributionTests, tempdir: Path, verbosity: Ver
         if verbosity is Verbosity.VERBOSE:
             verbose_log(f"{package.name}: Setting up venv in {venv_location}. {uv_command=}\n")
         try:
-            subprocess.check_output(uv_command, text=True, env=os.environ | {"VIRTUAL_ENV": venv_location})
+            subprocess.run(
+                uv_command, check=True, capture_output=True, text=True, env=os.environ | {"VIRTUAL_ENV": venv_location}
+            )
         except subprocess.CalledProcessError as e:
             _PRINT_QUEUE.put(f"{package.name}\n{e.stderr}")
             raise

diff --git a/tests/stubtest_third_party.py b/tests/stubtest_third_party.py
@@ -63,7 +63,7 @@ def run_stubtest(
     venv_dir = Path(tmp)
     try:
         try:
-            subprocess.check_output(["uv", "venv", venv_dir, "--seed"])
+            subprocess.run(["uv", "venv", venv_dir, "--seed"], capture_output=True, check=True)
         except subprocess.CalledProcessError as e:
             print_command_failure("Failed to create a virtualenv (likely a bug in uv?)", e)
             return False
@@ -93,7 +93,7 @@ def run_stubtest(
 
         pip_cmd = [pip_exe, "install", *dists_to_install]
         try:
-            subprocess.check_output(pip_cmd)
+            subprocess.run(pip_cmd, check=True, capture_output=True)
         except subprocess.CalledProcessError as e:
             print_command_failure("Failed to install", e)
             return False
@@ -133,7 +133,7 @@ def run_stubtest(
             return False
 
         try:
-            subprocess.check_output(stubtest_cmd, env=stubtest_env)
+            subprocess.run(stubtest_cmd, env=stubtest_env, check=True, capture_output=True)
         except subprocess.CalledProcessError as e:
             print_error("fail")