Fix basic pyright issues #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201e8f3 to
faaa82b
Compare
3a2d56a to
54e6096
Compare
Avasam
commented
Jan 25, 2024
Comment on lines
+79
to
+80
| if self.target_dir is None: | ||
| raise ValueError("self.target_dir cannot be None") |
There was a problem hiding this comment.
Suggested change
| if self.target_dir is None: | |
| raise ValueError("self.target_dir cannot be None") |
Avasam
commented
Jan 25, 2024
setuptools/config/pyprojecttoml.py
Outdated
| @@ -297,10 +297,13 @@ def _obtain(self, dist: "Distribution", field: str, package_dir: Mapping[str, st | |||
| def _obtain_version(self, dist: "Distribution", package_dir: Mapping[str, str]): | |||
| # Since plugins can set version, let's silently skip if it cannot be obtained | |||
| if "version" in self.dynamic and "version" in self.dynamic_cfg: | |||
| return _expand.version(self._obtain(dist, "version", package_dir)) | |||
| return _expand.version( | |||
| # We already an early dynamic check for the presense of "version" | |||
There was a problem hiding this comment.
Suggested change
| # We already an early dynamic check for the presense of "version" | |
| # We already do an early check for the presence of "version" |
Avasam
commented
Jan 25, 2024
| return None | ||
|
|
||
| def _obtain_readme(self, dist: "Distribution") -> Optional[Dict[str, str]]: | ||
| def _obtain_readme(self, dist: "Distribution") -> Optional[Dict[str, Optional[str]]]: |
There was a problem hiding this comment.
Suggested change
| def _obtain_readme(self, dist: "Distribution") -> Optional[Dict[str, Optional[str]]]: | |
| def _obtain_readme(self, dist: "Distribution") -> Optional[Dict[str, str]]: |
…tuptools into fix-basic-pyright-issues
bbb379f to
d9f74a7
Compare
872fc45 to
257efa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Step 2 of pypa#2345 (comment)
Pull Request Checklist
newsfragments/.(See documentation for details)