update FuncUI sample to preserve state when reloading #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one looks pretty neat do you know if there are performance issues with trace? (looks good to me btw) |
worldbeater
approved these changes
Aug 2, 2021
|
I haven't tested the performance, that said (probably another PR) I'd like the hot reload to be only active in dev. In production, we should have a compiler condition and return a standard window. |
|
Is there anything else I need to do? Who will merge this (I don't have the permissions to merge)? |
AngelMunoz
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements state preservation for the FuncUI sample.
Every time the state changes it is saved to window.DataContext and when CreateView is called the old state is converted to the new object by serialization and used as the initial state.
This is especially useful in Elmish programs where the state is centralized and therefore it's possible to restore all the state in all cases.