Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Fluent/Default themes out of main package #8148

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Theme and default theme aren't part of "Avalonia" package anymore.

Breaking changes

Yes! Developers will need to attach the theme what they actually use in their application.
Templates should be updated to include Fluent by default, so for new there won't be any confusion.

Fixed issues

Fixes #5593

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0020415-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Now is the right time to make this change I think,

@jmacato jmacato enabled auto-merge May 17, 2022 07:53
@jmacato jmacato merged commit 12ecfde into master May 17, 2022
@jmacato jmacato deleted the move-default-themes branch May 17, 2022 08:12
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0020418-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making Fluent and Default theme a separate NuGet package
4 participants