Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calendar in CalendarDatePicker Popup properly #7194

Merged

Conversation

timunie
Copy link
Contributor

@timunie timunie commented Dec 17, 2021

What does the pull request do?

Reflect changes to the Calendar in the Popup of CalendarDatePicker

What is the current behavior?

Any dynamic changes are not reflected by the Calendar

What is the updated/expected behavior with this PR?

changes to DisplayDateStart, DisplayDateEnd and SelectedDate should be reflected in the popup

How was the solution implemented (if it's not obvious)?

Added TemplateBinding for the needed properties

Checklist

  • Added unit tests (if possible)? ► changed the existing ones to work with the new code
  • Added XML documentation to any related classes? ► not needed
  • Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation ► not needed

Breaking changes

It is not a real breaking change but any custon style needs to be adopted to reflect these changes

Obsoletions / Deprecations

Result

image

Fixed issues

Fixes #7162

timunie and others added 2 commits December 20, 2021 15:42
- Use `TemplateBinding`
- Reflect changes of the blackout dates collection
- Revert listen to colleciton changes as the collection is already synced
- Setup the needed bindings in the test control
@timunie timunie force-pushed the fix/Issue_7162_CalendarPickerBindings branch from f72fc2d to f69e3e6 Compare December 20, 2021 14:42
@timunie timunie marked this pull request as ready for review December 20, 2021 14:43
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxkatz6 maxkatz6 enabled auto-merge December 21, 2021 00:33
@maxkatz6 maxkatz6 merged commit e8031ef into AvaloniaUI:master Dec 21, 2021
@timunie timunie deleted the fix/Issue_7162_CalendarPickerBindings branch December 21, 2021 07:10
danwalmsley pushed a commit that referenced this pull request Dec 21, 2021
…ndings

Update Calendar in CalendarDatePicker Popup properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CalendarDatePicker does not reflect changes in DisplayDateStart and DisplayDateEnd
3 participants