Add SplitView control #4174
Add SplitView control #4174
Conversation
SplitView use nameof
| <Style Selector="SplitView:overlay:left /template/ Panel#PART_PaneRoot"> | ||
| <Setter Property="Width" Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.ClosedPaneWidth}" /> | ||
| <!-- ColumnSpan should be 2 --> | ||
| <Setter Property="Grid.ColumnSpan" Value="1"/> |
There was a problem hiding this comment.
ColumnSpan should technically be 2 here (and also in :compactoverlay below). When I copied the code into Avalonia from my test project this broke and opening the pane would also move the content slightly, but only when the pane is on the left. Not sure why this is being handled differently...
There was a problem hiding this comment.
well.. could you try explicitly setting grid.column too? just in case there's some bug in there...
| <Grid Name="Container" Background="{TemplateBinding Background}"> | ||
| <Grid.ColumnDefinitions> | ||
| <!-- why is this throwing a binding error? --> | ||
| <ColumnDefinition Width="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.PaneColumnGridLength}"/> |
There was a problem hiding this comment.
This is throwing a binding error (you can see it on load or when you change the PanePlacement).
[Binding] Error in binding to 'Avalonia.Controls.ColumnDefinition'.'Width': 'Null value in expression ''.' (ColumnDefinition #41130254)
Like my comment below, this only started happening when I moved the code from my test project into avalonia. I know and have checked TemplateSettings.PaneColumnGridLength is not null so I'm not sure why this is happening.
|
|
| <Style Selector="SplitView:overlay:left /template/ Panel#PART_PaneRoot"> | ||
| <Setter Property="Width" Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.ClosedPaneWidth}" /> | ||
| <!-- ColumnSpan should be 2 --> | ||
| <Setter Property="Grid.ColumnSpan" Value="1"/> |
There was a problem hiding this comment.
well.. could you try explicitly setting grid.column too? just in case there's some bug in there...
|
@AvaloniaUI/core dont merge this yet.. i have an incoming PR for spline easing |
| /// <summary> | ||
| /// Defines constants for how the SplitView Pane should display | ||
| /// </summary> | ||
| public enum SplitViewDisplayMode |
There was a problem hiding this comment.
nit: I noticed that many controls is placed in root of Avalonia.Controls folder. Should we start to move controls and related classes/enums to specific sub folders?
There was a problem hiding this comment.
I think that would be a good idea for more complex controls that are not single file... what about namespace too?
There was a problem hiding this comment.
We should keep Avalonia.Controls, because it is convenient for developers.
There was a problem hiding this comment.
I agree here, I think the controls folder could be better organized this way. Would make it easier to find things too
Co-authored-by: Max Katz <maxkatz6@outlook.com>
Update SplitView easings to use what's in UWP's template instead of QuinticEaseOut.
|
@danwalmsley I believe I've addressed all you're comments |
|
@amwx could you explain how exactly overlay mode works? When I try render content over other controls (ie. adding them to same grid row) they appear on top of each other. It all happens just by ZIndex? |
|
@ShadowDancer In Overlay mode, the pane is supposed to display above content. Tho there is currently an issue with the SplitView in Overlay mode, because of a difference in behavior between the Avalonia source and the nuget package for some reason. So currently, Overlay mode displays like Inline. |
What does the pull request do?
Adds SplitView control from my FluentAvalonia repo with a few enhancements, primarily moving pane animation to Styles
Checklist