Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Replace deprecated functions with #setTimeouts #1216

Merged
merged 1 commit into from
May 23, 2018
Merged

Replace deprecated functions with #setTimeouts #1216

merged 1 commit into from
May 23, 2018

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented May 23, 2018

Fixes #1207

@brbrr brbrr self-assigned this May 23, 2018
@brbrr brbrr requested a review from a team May 23, 2018 08:56
@alisterscott
Copy link
Contributor

This looks great - thanks @brbrr

I noticed there's also a script timeout value - I wonder whether we should also set that? Maybe in a separate PR...

alisterscott
alisterscott approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@alisterscott alisterscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alisterscott alisterscott mentioned this pull request May 23, 2018
Open
@brbrr brbrr merged commit c321d94 into master May 23, 2018
@brbrr brbrr deleted the update/driver-set-timeouts branch May 23, 2018 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alisterscott alisterscott alisterscott approved these changes

Assignees

@brbrr brbrr

Labels
[Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brbrr @alisterscott