-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Update use-my-domain/domain-input comp to use fixMe #98024
base: update/i18n-introduce-fixme
Are you sure you want to change the base?
i18n: Update use-my-domain/domain-input comp to use fixMe #98024
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
? __( 'yourgroovydomain.com' ) | ||
: __( 'mydomain.com' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Automattic/i18n does use of __
suffer from same pitfalls with direct use of i18n-calypso
's translate
method? So should this be converted to translate
from useTranslate
hook?
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~97 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~13 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~13 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
5253a65
to
a2155e4
Compare
a2155e4
to
cde64ad
Compare
const domainPlaceholderLabel = fixMe( { | ||
text: 'yourgroovydomain.com', | ||
translation: __( 'yourgroovydomain.com' ), | ||
fallback: __( 'mydomain.com' ), | ||
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Automattic/i18n what's the best/preferred way to check if translations for yourgroovydomain.com
have been completed for all locales? I can find my way to check individual locales in GlotPress, but that doesn't help.
and I guess if the translations are complete, we'd instead just make this a __( 'yourgroovydomain.com' )
call (or use of translate
instead - per other comment)?
Related to https://github.com/Automattic/i18n-issues/issues/654
Proposed Changes
fixMe
method toi18n-calypso
#97690hasTranslation + locale
check with newfixMe
methodMedia
Why are these changes being made?
Part of addressing https://github.com/Automattic/i18n-issues/issues/654
Testing Instructions
/start/domains/use-your-domain
with en localeyourgroovydomain.com
and confirm the sameyourgroovydomain.com
and confirm the translation formydomain.com
shows instead for placeholder textPre-merge Checklist