Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update use-my-domain/domain-input comp to use fixMe #98024

Open
wants to merge 1 commit into
base: update/i18n-introduce-fixme
Choose a base branch
from

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Jan 7, 2025

Related to https://github.com/Automattic/i18n-issues/issues/654

Proposed Changes

Media

Screenshot 2025-01-07 at 3 44 25 PM

Why are these changes being made?

Part of addressing https://github.com/Automattic/i18n-issues/issues/654

Testing Instructions

  • Go to /start/domains/use-your-domain with en locale
  • Confirm media above
  • Try with a different locale that has a translation for yourgroovydomain.com and confirm the same
  • Try with a different locale that does not have a translation for yourgroovydomain.com and confirm the translation for mydomain.com shows instead for placeholder text

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds self-assigned this Jan 7, 2025
@chriskmnds chriskmnds added the i18n label Jan 7, 2025
Comment on lines -53 to -54
? __( 'yourgroovydomain.com' )
: __( 'mydomain.com' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Automattic/i18n does use of __ suffer from same pitfalls with direct use of i18n-calypso's translate method? So should this be converted to translate from useTranslate hook?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-fixme-use-my-domain on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~97 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         +290 B  (+0.0%)      +97 B  (+0.0%)
entry-stepper               +290 B  (+0.0%)      +97 B  (+0.0%)
entry-main                  +290 B  (+0.0%)      +97 B  (+0.0%)
entry-login                 +290 B  (+0.0%)      +97 B  (+0.0%)
entry-domains-landing       +290 B  (+0.0%)      +97 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~13 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          -60 B  (-0.0%)      -13 B  (-0.0%)
link-in-bio-tld-flow        -60 B  (-0.0%)      -13 B  (-0.0%)
domains                     -60 B  (-0.0%)      -13 B  (-0.0%)
copy-site-flow              -60 B  (-0.0%)      -13 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~13 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        -60 B  (-0.0%)      -13 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds force-pushed the update/i18n-fixme-use-my-domain branch from 5253a65 to a2155e4 Compare January 7, 2025 13:43
@chriskmnds chriskmnds force-pushed the update/i18n-fixme-use-my-domain branch from a2155e4 to cde64ad Compare January 7, 2025 13:46
Comment on lines +49 to +53
const domainPlaceholderLabel = fixMe( {
text: 'yourgroovydomain.com',
translation: __( 'yourgroovydomain.com' ),
fallback: __( 'mydomain.com' ),
} );
Copy link
Contributor Author

@chriskmnds chriskmnds Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Automattic/i18n what's the best/preferred way to check if translations for yourgroovydomain.com have been completed for all locales? I can find my way to check individual locales in GlotPress, but that doesn't help.

and I guess if the translations are complete, we'd instead just make this a __( 'yourgroovydomain.com' ) call (or use of translate instead - per other comment)?

@chriskmnds chriskmnds marked this pull request as ready for review January 7, 2025 13:58
@chriskmnds chriskmnds requested a review from a team January 7, 2025 13:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants