Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: update the preferred editor view #97399

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

BogdanUngureanu
Copy link
Contributor

This PR uses the newly added use_core_editor property available in the admin menu editor - allowing us to control from the back-end which editor to use.

Fix: #97396

Proposed Changes

  • Use the use_core_editor property from the API to determine which editor to use.

Why are these changes being made?

  • We need this to be able to stop the iframe editor redirecting to the core one when the users are part of the treatment group of the remove duplicate views experiment.

Testing Instructions

  • Use the live link
  • Sandbox your Simple site with this Jetpack PR
  • go to wp-admin/edit.php and grab an edit link from the posts list.
  • Replace WordPress.com domain with the Calypso.live link domain
  • Open the link and notice that you're not redirected to the Core Editor anymore

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

This PR uses the newly added use_core_editor available in the admin menu editor - allowing us to control from the back-end which editor to use.
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/calypso-editor-iframe-update-redirect-logic on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~10 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -18 B  (-0.0%)      -10 B  (-0.0%)
entry-main           -18 B  (-0.0%)      -10 B  (-0.0%)
entry-login          -18 B  (-0.0%)      -10 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate views: Keep using iframed editor
2 participants