Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix Map block test #95290

Merged
merged 1 commit into from
Oct 10, 2024
Merged

e2e: Fix Map block test #95290

merged 1 commit into from
Oct 10, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Oct 10, 2024

Proposed Changes

Switch the test to look for the placeholder specifically, instead of the name, which will work with both the old and new code.

Why are these changes being made?

Automattic/jetpack#39708 associated the "Add a location" <label> with the <input>, which makes Playwright use that as the accessible name for the input rather than the input's placeholder.

Testing Instructions

  • Run the test against jetpackedge sites and other sites, e.g.
    • yarn workspace wp-e2e-tests build && VIEWPORT_NAME="desktop" ATOMIC_VARIATION="default" TEST_ON_ATOMIC="true" JETPACK_TARGET="wpcom-deployment" yarn workspace wp-e2e-tests test test/e2e/specs/blocks/blocks__jetpack-other.ts
    • yarn workspace wp-e2e-tests build && VIEWPORT_NAME="desktop" TEST_ON_ATOMIC="true" yarn workspace wp-e2e-tests test test/e2e/specs/blocks/blocks__jetpack-other.ts
    • yarn workspace wp-e2e-tests build && VIEWPORT_NAME="desktop" yarn workspace wp-e2e-tests test test/e2e/specs/blocks/blocks__jetpack-other.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Automattic/jetpack#39708 associated the "Add a location" `<label>` with
the `<input>`, which makes Playwright use that as the accessible name
for the input rather than the input's placeholder.

Switch the test to look for the placeholder specifically, instead of the
name, which will work with both the old and new code.
@anomiex anomiex added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 10, 2024
@anomiex anomiex requested a review from a team October 10, 2024 16:55
@anomiex anomiex self-assigned this Oct 10, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@anomiex anomiex merged commit 1643419 into trunk Oct 10, 2024
13 checks passed
@anomiex anomiex deleted the fix/e2e-map-block-test branch October 10, 2024 18:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants