-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert update webpack packages #91443
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing E2E tests seem unrelated (see p1717487713672789-slack-C02DQP0FP)
It'd be great if you could follow up on this. Thanks @tyxla! |
Investigating and will submit a fix in #91454. I've reverted to the supposedly broken state, but I can't reproduce. I'm following your (inverted) steps from above with the reverted branch, but can't reproduce it. Could you try with #91454 and let me know what I might be missing? Command I'm testing with:
|
I managed to reproduce it and will work on a fix, stay tuned. |
Seems like it will have to wait until 6.6 is released, see WordPress/gutenberg#62202 |
Proposed Changes
Partially reverts #91367 because it was breaking the
command-palette-wp-admin
app (unsure if it was breaking other apps too).Why are these changes being made?
To fix the
command-palette-wp-admin
appTesting Instructions
install-plugin.sh command-palette-wp-admin trunk
widgets.wp.com
and a simple site/wp-admin
on your sandboxed sitebuild.min.js?ver=20240604:6 Uncaught TypeError: Cannot read properties of undefined (reading 'jsx')
install-plugin.sh command-palette-wp-admin revert/webpack-packages-updates
/wp-admin
and open the command palettePre-merge Checklist