Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State: update Array.find usage to use lodash #7722

Merged
merged 1 commit into from
Aug 30, 2016
Merged

State: update Array.find usage to use lodash #7722

merged 1 commit into from
Aug 30, 2016

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Aug 29, 2016

This fixes an Array.find usage. We don't have a full polyfill solution for prototype methods (see #6117 ) so this will break in IE

Testing Instructions

cc @yurynix

Test live: https://calypso.live/?branch=fix/ie-find

@gwwar gwwar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial State labels Aug 29, 2016
@gwwar gwwar self-assigned this Aug 29, 2016
@yurynix
Copy link
Contributor

yurynix commented Aug 30, 2016

Live branch failing for me.
screen shot 2016-08-30 at 10 07 36 am

cc @Tug

@Tug
Copy link
Contributor

Tug commented Aug 30, 2016

Thanks for notifying me @yurynix. I had to remove the branch manually on the server because of this node-sass error. I often have this error myself locally and have to remove the dependency manually to make it work again...

@yurynix
Copy link
Contributor

yurynix commented Aug 30, 2016

I've checked that branch locally, looks good to me 👍

@yurynix yurynix added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 30, 2016
@blowery blowery merged commit 4ac589a into master Aug 30, 2016
@blowery blowery deleted the fix/ie-find branch August 30, 2016 16:39
@gwwar
Copy link
Contributor Author

gwwar commented Aug 30, 2016

Thanks for the reviews and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants