E2E: add test to check admin bar presence in mobile. #57579
Conversation
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-18361 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
b747130 to
b4ad308
Compare
| const frame = await this.getEditorFrame(); | ||
| await frame.click( selectors.dashboardLink ); | ||
| const navbarComponent = new NavbarComponent( this.page ); | ||
| const actions: unknown[] = [ |
There was a problem hiding this comment.
I believe we know the type here, right? It's a Promise<any>[] I believe!
There was a problem hiding this comment.
Ah yes I was missing the Promise part. Reason why I chose unknown is because the transpiler won't show me a warning that way :P
| */ | ||
| async returnToDashboard(): Promise< void > { | ||
| async returnToHomeDashboard(): Promise< void > { |
There was a problem hiding this comment.
Optional: but I kind of feel like that function should take care of opening the nav sidebar for desktop if needed. It feels a little weird that people using this function have to include a call to openNavSidebar in their specs before it, but that only matters for the desktop case.
| @@ -0,0 +1,37 @@ | |||
| /** | |||
| * @group gutenberg | |||
There was a problem hiding this comment.
I think we should run this on calypso-pr runs, right? That navbar is pure calypso, and we override some stuff in the nav sidebar, so I think it's directly relevant to PR runs!
There was a problem hiding this comment.
Oh, I completely forgot about this one - I copy-pasted the test contents and simply forgot to update it.
- support both mobile and desktop sizes
Add new sped `Editor: Navbar`
- open the sidebar as part of the returning to home dashboard. - change type of the action array.
650b97b to
0d0c748
Compare
* Change how `openNavSidebar` and `returnToHomeDashboard` works. - support both mobile and desktop sizes * Update tests * Use an array of promises intead. Add new sped `Editor: Navbar` * Fix lint error. * Another lint error. * Minor updates from code review. - open the sidebar as part of the returning to home dashboard. - change type of the action array.
Changes proposed in this Pull Request
This PR adds a test as per #57190 to check the presence and basic functionality of the admin bar (also called navbar).
Key changes:
:visiblepseudo-CSS.Details:
Changes in this PR arose from the parent issue #57190 and #51162 where on the mobile web editor no methods were provided for the user to exit the editor back to WordPress.com.
The changes in #57234 were to persistently show the navbar in the editor view, so the user can click on
My Sitesto return to WordPress.com.However, this means that experience of exiting the editor differs depending on the viewport size used:
The method
openNavSidebarhas been restructured so that it only performs its action on desktop.Similarly,
returnToHomeDashboardhas been restructured to handle both scenarios.Testing instructions
Closes #57190.