Site Editor: fix loading order on Dotcom after 8.9.0 update

[vindl]

Changes proposed in this Pull Request

Fixes the broken site editor on Dotcom by making sure that experiment option is
overridden on time.

Testing instructions

1. Make sure that you are using the site with Gutenberg edge sticker.
2. Apply the generated patch and make sure that the site editor loads.

[matticbot]

Test live: https://calypso.live/?branch=fix/site-editor-loading

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D48970-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[Copons]

I've applied the patch and sandboxed a site with core-site-editor-enabled and gutenberg-edge stickers.

In the front end I see dozens of these errors:

[Suppressed] Warning: DOMDocument::loadHTML(): Tag nav invalid in Entity, line: 1 in wp-content/plugins/gutenberg-core/8.9.0-rc.1/lib/block-supports/index.php on line 63

While the Site Editor (wp-admin/admin.php?page=gutenberg-edit-site) doesn't load, I think because it gets stuck with this request:

https://public-api.wordpress.com/wp/v2/sites/{ siteId }/types/null

[vindl]

While the Site Editor (wp-admin/admin.php?page=gutenberg-edit-site) doesn't load, I think because it gets stuck with this request:

@Copons I think this is a separate issue unrelated to loading order. I tried reverting the relevant Gutenberg loading change on a sandbox and edge stickered site and it's still happening.

[Copons]

While the Site Editor (wp-admin/admin.php?page=gutenberg-edit-site) doesn't load, I think because it gets stuck with this request:

@Copons I think this is a separate issue unrelated to loading order. I tried reverting the relevant Gutenberg loading change on a sandbox and edge stickered site and it's still happening.

You're right.
I've tried removing gutenberg-edge and the null request happens all the same, but the site editor loads fine. 🤔

[vindl]

I've tried removing gutenberg-edge and the null request happens all the same, but the site editor loads fine. 🤔

There are probably multiple issues. 😕

[jeyip]

While the Site Editor (wp-admin/admin.php?page=gutenberg-edit-site) doesn't load, I think because it gets stuck with this request:

https://public-api.wordpress.com/wp/v2/sites/{ siteId }/types/null

Looking into this now. If anyone else is investigating as well, I'd love to hop on a video call together. :)

[ockham]

I've applied the patch and sandboxed a site with core-site-editor-enabled and gutenberg-edge stickers.

In the front end I see dozens of these errors:

[Suppressed] Warning: DOMDocument::loadHTML(): Tag nav invalid in Entity, line: 1 in wp-content/plugins/gutenberg-core/8.9.0-rc.1/lib/block-supports/index.php on line 63

This is fixed by WordPress/gutenberg#24677, which is included in the final v8.9.0 (but wasn't in the Release Candidate).

Edit: We've now updated Edge to v8.9.0, so those errors should be gone now.

[Addison-Stavlo]

Approving this change as it does seem to fix the issue with when this is executed. The other issues seem like they may be a separate task.

Looking at the other issue further, I seem to have one site that is loading perfectly fine after this change and another that is going into the site editor and never fully loading. Same errors on each 🤷‍♀️

[vindl]

Thanks @Addison-Stavlo, I'll merge this for now and we can continue looking into further errors.