FSE: Fix JS unit tests #39326
Merged
FSE: Fix JS unit tests #39326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the passing tests in CircleCi by following the link |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
2 tasks
tyxla
reviewed
Feb 10, 2020
|
@tyxla Nice to see you again! :) You can see the tests in this test suite:
|
This way, everything can be consistent within the plugin
- Make it work better in the monoreo environment - Move to bin folder
- Use test:* for test commands - Move config to bin/folder
See https://github.com/Automattic/wp-calypso/pull/39120/files In the above PR, the title was removed from the template selector. Apparently, the tests were not correctly executing until now, so the tests nedeed an update to stop referencing that title. Additionally, one snapshot nedeed updated. I guess the current test config in prod is not working correctly.
Co-Authored-By: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
27a16e5 to
b73bb5a
Compare
vindl
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR was split from #39000
This PR makes JS unit tests more consistent (in preparation for also having e2e and phpunit tests.) It also fixes several issues with the test suite.
Changes proposed in this Pull Request
.test.jsfor easier detection (and to be consestent with .spec.js e2e tests)bin/JS unit and UI tests
The unit test command automatically runs test files that:
apps/full-site-editing.test.js(or .ts, .tsx, jsx)To run JS unit/component/ui tests:
npx lerna run test:js --scope='@automattic/full-site-editing' --streamTesting instructions
npx lerna run test:js --scope='@automattic/full-site-editing' --stream --no-prefixon the CLI and the tests should pass.