Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: Fix DomainSuggestionsQuery type #38219

Closed
wants to merge 2 commits into from
Closed

Gutenboarding: Fix DomainSuggestionsQuery type #38219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047cf04
Gutenboarding: Fix DomainSuggestionQuery type
ockham Dec 5, 2019
7affbed
Gutenboarding: Simplify an enum export
ockham Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions client/landing/gutenboarding/stores/domain-suggestions/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
enum ActionType {
/**
* External dependencies
*/
import { InputArgs } from '@wordpress/url';

export enum ActionType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, did we need this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be exported. Want to add it in #38401?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being exported, just on a separate line. I can add the change to #38401 though.

RECEIVE_DOMAIN_SUGGESTIONS = 'RECEIVE_DOMAIN_SUGGESTIONS',
}
export { ActionType };

export interface DomainSuggestionQuery {
// We're extending InputArgs in order to add an index signature,
// which we need for using `DomainSuggestionQuery` objects with `addQueryArgs`.
export interface DomainSuggestionQuery extends InputArgs {
/**
* True to include .blog subdomain suggestions
*
Expand Down