-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-packages:watch script #37802
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. The only downside I see is that it rebuilds all of the packages if any one changes, but I'm not sure if there's an easy way around that. Maybe if we added a separate watch script for each package, but I don't know if the downside is worth that effort. 🤔 Still, I think it's better than what we have now.
I agree this isn't ideal -- for one thing as TypeScript usage grows the cost of unnecessary |
Agreed, let's keep it fairly simple for now. Thanks for putting this together! |
down the road, another option would be to add a |
Changes proposed in this Pull Request
build-packages:watch
script, which useschokidar-cli
to watch and rebuild source files inpackages/
.build-packages:watch
with main watcher scripts duringpoststart
.Testing instructions
Run
npm start
, then make changes somewhere inpackages/