Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Checklist: Fix backups completion state when provisioning #32273

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 15, 2019

Changes proposed in this Pull Request

  • Consider Backups task to be "completed" when Rewind is in "provisioning" state. See p9rlnk-1R-p2 for explanation of why.

Testing instructions

  • Checkout this branch.
  • Go to http://calypso.localhost:3000/settings/security/:site where `:site is a Pressable site.
  • Make sure your Jetpack Backups credentials are missing, revoke them if you have any.
  • Go to http://calypso.localhost:3000/plans/my-plan/:site.
  • Click on the "Do it" button on the Backup and Scan task.
  • Be very quick about the next clicks.
  • Follow through the tour and auto-configure credentials, then quickly go back to the to the checklist by clicking the "Yes, let's do it." button in the last tour step.
  • Verify the "Backup and Scan" task is shown as completed.

Previously, if you were quick enough to go back to the checklist while Rewind is still provisioning, the Backup and Scan task would be displayed as unfinished. This behavior has been reported by several folks who tested #32152.

Part of #32248.

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Jetpack [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. NUX Checklist labels Apr 15, 2019
@tyxla tyxla requested a review from a team April 15, 2019 11:07
@tyxla tyxla self-assigned this Apr 15, 2019
@matticbot
Copy link
Contributor

@ockham
Copy link
Contributor

ockham commented Apr 16, 2019

  • Click on the "Do it" button on the Backup and Scan task.
  • Be very quick about the next clicks.
  • Follow through the tour and auto-configure credentials, then quickly go back to the to the checklist by clicking the "Yes, let's do it." button in the last tour step.

Uh what do I click here?

image

@ockham
Copy link
Contributor

ockham commented Apr 16, 2019

  • Click on the "Do it" button on the Backup and Scan task.
  • Be very quick about the next clicks.
  • Follow through the tour and auto-configure credentials, then quickly go back to the to the checklist by clicking the "Yes, let's do it." button in the last tour step.

Uh what do I click here?

image

Uh nvm. The big plus next to it. I remember adding that box at one point myself 😅

It would help though if it actually pointed at that thing instead of just floating there.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, was able to test. Works as described 👍

@ockham
Copy link
Contributor

ockham commented Apr 16, 2019

  • Click on the "Do it" button on the Backup and Scan task.
  • Be very quick about the next clicks.
  • Follow through the tour and auto-configure credentials, then quickly go back to the to the checklist by clicking the "Yes, let's do it." button in the last tour step.

Uh what do I click here?
image

Uh nvm. The big plus next to it. I remember adding that box at one point myself

It would help though if it actually pointed at that thing instead of just floating there.

Ah, that's probably #32271?

@tyxla
Copy link
Member Author

tyxla commented Apr 16, 2019

Ah, that's probably #32271?

Yes 😉

Thanks @ockham!

@tyxla tyxla merged commit 15a2750 into master Apr 16, 2019
@tyxla tyxla deleted the fix/jetpack-checklist-rewind-completion-state branch April 16, 2019 13:37
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checklist Jetpack NUX [Pri] Normal Schedule for the next available opportuinity. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants