Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Checklist: Move all tasks to constants #32272

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Jetpack Checklist: Move all tasks to constants #32272

merged 2 commits into from
Apr 16, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 15, 2019

As @simison suggested in #31547 (comment) this PR moves the remaining tasks to the constants file so they'll all live in the same place.

Changes proposed in this Pull Request

  • Move Protect task definition to constants
  • Move Akismet task definition to constants

Testing instructions

@tyxla tyxla added Jetpack [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. NUX [Type] Janitorial Checklist labels Apr 15, 2019
@tyxla tyxla requested a review from a team April 15, 2019 10:42
@tyxla tyxla self-assigned this Apr 15, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/jetpack-checklist-move-to-constants

@tyxla tyxla changed the title Update/jetpack checklist move to constants Jetpack Checklist: Move all tasks to constants Apr 15, 2019
ockham
ockham approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tyxla tyxla merged commit 22dc2ac into master Apr 16, 2019
@tyxla tyxla deleted the update/jetpack-checklist-move-to-constants branch April 16, 2019 13:38
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham approved these changes

Assignees

@tyxla tyxla

Labels
Checklist Jetpack NUX [Pri] Normal Schedule for the next available opportuinity. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyxla @matticbot @ockham