Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve async checklist code. Follow-up to #27926 #28678

Merged
merged 7 commits into from
Nov 19, 2018
Merged

Improve async checklist code. Follow-up to #27926 #28678

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef058da
Add some error checking to URL generation
sgomes Nov 19, 2018
2c65963
Move render/no-render and notify/no-notify logic to connect.
sgomes Nov 19, 2018
d74e1a7
Rename query constant in component.jsx
sgomes Nov 19, 2018
f97e121
Use canonical name for component loading
sgomes Nov 19, 2018
e5178cd
Remove unused track prop from banner-mode checklist.
sgomes Nov 19, 2018
9eb4391
Tweak in component.js to make it less fragile.
sgomes Nov 19, 2018
7ffd98f
Re-enable tracking for banner close.
sgomes Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions client/my-sites/checklist/wpcom-checklist/checklist-banner/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@ export class ChecklistBanner extends Component {
setNeverShowBannerStatus( siteId, true );

this.setState( { closed: true } );

if ( this.props.track ) {
this.props.track( 'calypso_checklist_banner_close', {
site_id: siteId,
} );
}
Copy link
Member

@jsnajdr jsnajdr Nov 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original author clearly had intent to send the calypso_checklist_banner_close tracks event, but then something went wrong 😄 Let's make the tracks call work great again.

It got broken in this commit: 29af3b0. Part of #26764 by @ockham and @sirreal.

That commit removes file my-sites/stats/checklist-banner/index.jsx which connected the track prop to recordTracksEvent action.

And creates a new file, my-sites/checklist/wpcom-checklist/checklist-banner/index.js, which still calls this.props.tracks, but doesn't do the connect. ⚡️💥

Copy link
Member

@sirreal sirreal Nov 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this 🙇

Will note the affected period: 623-gh-tracks-events-validation-status

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest commit adds it back in correctly! :) Could one of you please double-check the code looks good?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jsnajdr ! Also, by the way, excellent sleuthing work!

};

render() {
Expand Down