Checklist: Update task url based on headstarted posts #26758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
791e2d7 to
d987968
Compare
|
Rebased. |
|
It looks good and works fine. Will the PR also work well if the site has, let's say, 1000 posts? EDIT: of course it will, I noticed that the order is by ID ASC only after creating a test site with 10 test pages :) |
|
@dzver Yes, it will. With this update, the checklist retrieves first 10 posts only(including pages). I don't think it is too big to handle. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A checklist task may need to change the destination URL based on the posts. For instance, "Publish your first blog post" task create a new post by default. However, once a user published a post, the task should head for it instead.
This url logic is currently placed on the server-side, but it would be better if we could move the logic to Calypso. That's what this PR handles.
How to test
public-api.wordpress.com4-1. "Personalize your Contact page" task should head for the new contact page instead of
/post/YOUR_SITE/2.4-2. "Publish your first blog post" task should not create a new post.