Guided tour: Jetpack guided checklist links to "My Plan" #26043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
reviewed
Jul 13, 2018
| @@ -67,7 +69,7 @@ export const JetpackMonitoringTour = makeTour( | |||
| ) } | |||
| </p> | |||
| <ButtonRow> | |||
| <SiteLink isButton href={ '/checklist/:site' }> | |||
| <SiteLink isButton href={ '/plans/my-plan/:site' }> | |||
There was a problem hiding this comment.
We could turn the { '...' }s into "..."s while we're here (also below). Probably my bad 😅
ockham
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetpack checklists will be shown at
/plans/my-plan/SITE_SLUG. Jetpack guided tours that "return" or otherwise link to the related checklist should send users to that route.Update relevant guided tours.
#26042 Adds redirection from
/checklist/SITE_SLUGto/plans/my-plan/SITE_SLUGfor Jetpack sites, so "generic" tours should continue to work well. This change avoids that unnecessary redirection for Jetpack tours.Closes #26041
Testing
/plans/my-plan/JETPACK_SITE_SLUG.