-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChecklistShow: Decouple tasks
prop
#25958
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dc414b
to
aa89a49
Compare
aa89a49
to
35fa110
Compare
Rebased (new node version) |
35fa110
to
103fa35
Compare
Rebased |
I'm not sure this aligns with the direction outlined in #26015 Before reviewing this fully, I'm going to do some exploration to see what implementing those changes might look like. |
5 tasks
I'd like to go with #26216 over this, it's about ready 😁 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the responsibility to provide a
tasks
array prop to theChecklist
prop from theChecklistShow
wrapper to its consumer. The rationale is that for https://github.com/Automattic/wp-calypso/projects/70, the logic providing that prop will diverge for JP sites from how we're doing it for WP.com ones, since in the Jetpack case, we want to display 'pending' state for some steps (spinners), which we'll infer from selectors (essentially plugin installation state, see #25935). To that end, we want to be able to transparently extend thetasks
array in theconnect()
that is relevant for the JP case.Note that this PR changes behavior: the checklist for JP sites is now only available at
/plans/my-plan/:site
, whereas/checklist/:site
will no longer show a checklist for JP sites (only for WP.com).Testing Instructions
Verify that the checklist still works for WP.com sites
http://calypso.localhost:3000/checklist/<wpcomSite>
/plans/my-plan/<jpSite>
going forward.)Verify that the checklist still works for Jetpack sites
http://calypso.localhost:3000/checklist/<jpSite>
propType
errors in the console are pre-existing onmaster
.