Plans: Add Checklist to My Plan page (JP) #25870

ockham · 2018-07-04T17:02:05Z

Screenshot

Testing Instructions

Navigate to http://calypso.localhost:3000/plans/my-plan/<jpSite>
Verify that you see the checklist as in the screenshot above
Verify that the checklist is fully functional (Note that only the Jetpack Monitor task's 'Do it' button will currently start a Guided Tour)
Navigate that no checklist is shown for WP.com sites, i.e. http://calypso.localhost:3000/plans/my-plan/<wpcomSite>
Verify that the checklist is hidden behind a feature flag:
Apply the patch below and restart Calypso. Verify that the checklist is no longer shown on http://calypso.localhost:3000/plans/my-plan/<jpSite>

diff --git a/config/development.json b/config/development.json
index bc77f97..773cd30 100644
--- a/config/development.json
+++ b/config/development.json
@@ -68,7 +68,7 @@
                "help/courses": true,
                "i18n/community-translator": false,
                "jetpack/api-cache": true,
-               "jetpack/checklist": true,
+               "jetpack/checklist": false,
                "jetpack/connect-redirect-pressable-credential-approval": true,
                "jetpack/connect/remote-install": true,
                "jetpack/connect/mobile-app-flow": true,

Fixes #25871

matticbot · 2018-07-04T17:02:07Z

Test live: https://calypso.live/?branch=add/checklist-to-my-plan-page

a8ci18n · 2018-07-08T13:05:48Z

client/my-sites/checklist/main.jsx

+
+		return (
+			<FormattedHeader
+				headerText={ translate( 'Welcome back!' ) }


Hi! I've found a possible matching string that has already been translated 24 times:
translate( 'Welcome Back :)' ) ES Score: 15
See 1 additional suggestion in the PR translation status page

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2018-07-08T13:05:49Z

client/my-sites/checklist/main.jsx

+		const { translate } = this.props;
+
+		if ( displayMode === 'free' ) {
+			return translate( 'Your site has been created!' );


Hi! I've found a possible matching string that has already been translated 2 times:
translate( 'Your new site has been created!' ) ES Score: 10

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

This reverts commit 23b2fbe6ba6e6b6bcbbb461a3dd52d941993290e.

sirreal · 2018-07-10T08:28:48Z

The checklist was showing for Atomic sites, I've just pushed a change to hide it for those sites.

sirreal · 2018-07-10T08:37:37Z

A note on this flow:

Connect a new Jetpack site via /jetpack/connect
End of the flow is /plans/my-plan/:SITE_SLUG
Guided tour starts
End of guided tour is not the my-plan page.

Step 2 lands on the plans page. Presumably the intention is to incite users to investigate plans offerings.

By step 4 they've been whisked away through a series of steps. Now they don't see plans or the checklist added by this PR.

cc: @joanrho

sirreal

A few notes about functionality, likely none are introduced by this PR

My first checklist item is for Jetpack Monitor. I click the task, enable the setting and return. I believe the settings API request hasn't completed and the checklist item remains unchecked. If I click again and return to the checklist, it is.
Is "Automatic Plugin Updates" enabled? When I click that item, no help appears.
The end of the checklist steps returns to /checklist/:SITE_SLUG rather than /plans/my-plan/:SITE_SLUG. It would be nice to "return" to where you started from.

Feature flag works well 👍

sirreal

If the notes I mentioned aren't related to this PR, should be good to 🚢

ockham · 2018-07-10T09:17:22Z

My first checklist item is for Jetpack Monitor. I click the task, enable the setting and return. I believe the settings API request hasn't completed and the checklist item remains unchecked. If I click again and return to the checklist, it is.

Yeah, I was thinking of adding some Redux logic to reflect that change right after it's been made (or maybe even show a loading spinner while the network request hasn't returned yet, see #25935).

Is "Automatic Plugin Updates" enabled? When I click that item, no help appears.

The corresponding Guided Tour hasn't been merged yet (#25474).

The end of the checklist steps returns to /checklist/:SITE_SLUG rather than /plans/my-plan/:SITE_SLUG. It would be nice to "return" to where you started from.

Ah yup, I forgot to add a note about that, sorry. Guided Tours right now hard-code where they finish, and right now, that points to /checklist/:site (where we had enabled the checklist earlier for testing, to align with WP.com checklists). We need to fix that by pointing to the 'My Plan' page instead (and probably add a redirect from /checklist/:site to that page for JP sites).

Thanks for reviewing! Going to merge & file cards/issues so we don't forget about items 1 and 3.

joanrho · 2018-07-10T16:16:36Z

@ockham Don't we end all Guided Tours with Notices that link to "Go back to checklist"?

ockham · 2018-07-11T12:12:05Z

@ockham Don't we end all Guided Tours with Notices that link to "Go back to checklist"?

Uh yeah -- I thought I'd just change the Jetpack specific ones to point to /plans/my-plan/:SITE_SLUG instead of /checklist/:SITE_SLUG. Think that's okay? Or am I missing something?

joanrho · 2018-07-11T16:56:00Z

@ockham ah yes, that's exactly what we want to do, since /checklist doesn't have a home yet. Just confirming all GTs end in notices with the link back to My Plan page (our checklist).

ockham · 2018-07-12T18:09:21Z

Cool! FWIW, I've filed a card on the project board for this, https://github.com/Automattic/wp-calypso/projects/70#card-11207580

ockham added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] In Progress Checklist labels Jul 4, 2018

ockham self-assigned this Jul 4, 2018

ockham force-pushed the add/checklist-to-my-plan-page branch 3 times, most recently from 4826c1d to bc92484 Compare July 6, 2018 13:53

ockham mentioned this pull request Jul 6, 2018

Checklist (My Sites): Componentize #25901

Merged

ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jul 6, 2018

ockham requested a review from a team July 6, 2018 14:57

ockham force-pushed the add/checklist-to-my-plan-page branch from 488799d to 5619fb6 Compare July 8, 2018 13:03

a8ci18n reviewed Jul 8, 2018

View reviewed changes

ockham added 4 commits July 9, 2018 10:19

Plans: Add Checklist to My Plan page (JP)

7fd969d

Embed directly

53d4a77

Revert "Embed directly"

daf315f

This reverts commit 23b2fbe6ba6e6b6bcbbb461a3dd52d941993290e.

Feature Flag

32dc24d

ockham force-pushed the add/checklist-to-my-plan-page branch from 5619fb6 to 32dc24d Compare July 9, 2018 08:19

sirreal added 2 commits July 10, 2018 10:27

Remove duplicate selector call

7327795

Disable checklist for Atomic

44809eb

sirreal reviewed Jul 10, 2018

View reviewed changes

sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 10, 2018

sirreal approved these changes Jul 10, 2018

View reviewed changes

ockham merged commit 321b938 into master Jul 10, 2018

ockham deleted the add/checklist-to-my-plan-page branch July 10, 2018 09:20

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plans: Add Checklist to My Plan page (JP) #25870

Plans: Add Checklist to My Plan page (JP) #25870

ockham commented Jul 4, 2018 •

edited

Loading

matticbot commented Jul 4, 2018

a8ci18n Jul 8, 2018

a8ci18n Jul 8, 2018

sirreal commented Jul 10, 2018

sirreal commented Jul 10, 2018

sirreal left a comment •

edited

Loading

sirreal left a comment

ockham commented Jul 10, 2018 •

edited

Loading

joanrho commented Jul 10, 2018 •

edited

Loading

ockham commented Jul 11, 2018

joanrho commented Jul 11, 2018 •

edited

Loading

ockham commented Jul 12, 2018

Plans: Add Checklist to My Plan page (JP) #25870

Plans: Add Checklist to My Plan page (JP) #25870

Conversation

ockham commented Jul 4, 2018 • edited Loading

Screenshot

Testing Instructions

matticbot commented Jul 4, 2018

a8ci18n Jul 8, 2018

Choose a reason for hiding this comment

a8ci18n Jul 8, 2018

Choose a reason for hiding this comment

sirreal commented Jul 10, 2018

sirreal commented Jul 10, 2018

sirreal left a comment • edited Loading

Choose a reason for hiding this comment

sirreal left a comment

Choose a reason for hiding this comment

ockham commented Jul 10, 2018 • edited Loading

joanrho commented Jul 10, 2018 • edited Loading

ockham commented Jul 11, 2018

joanrho commented Jul 11, 2018 • edited Loading

ockham commented Jul 12, 2018

ockham commented Jul 4, 2018 •

edited

Loading

sirreal left a comment •

edited

Loading

ockham commented Jul 10, 2018 •

edited

Loading

joanrho commented Jul 10, 2018 •

edited

Loading

joanrho commented Jul 11, 2018 •

edited

Loading