Framework: Convert renderWithReduxStore import to CommonJS #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Could we import file which will require and call polyfill instead? This should work with properly with transpilation. |
3 tasks
gziolo
reviewed
Mar 29, 2017
| @@ -50,11 +50,11 @@ var config = require( 'config' ), | |||
| syncHandler = require( 'lib/wp/sync-handler' ), | |||
| bindWpLocaleState = require( 'lib/wp/localization' ).bindState, | |||
| supportUser = require( 'lib/user/support-user-interop' ), | |||
| createReduxStoreFromPersistedInitialState = require( 'state/initial-state' ).default; | |||
| createReduxStoreFromPersistedInitialState = require( 'state/initial-state' ).default, | |||
| renderWithReduxStore = require( 'lib/react-helpers' ).renderWithReduxStore; | |||
There was a problem hiding this comment.
From what I tested it also helps when you postpone execution of require( 'lib/user' ) until it is really needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where Safari Private Mode does not load because there are dependencies defined in ES2015 import syntax in the boot file which assume the presence of
localStorage. When transpiled, these imports are placed before the localStorage polyfillrequireand therefore throw an error in Safari Private Mode on attempt to use the unpolyfilled localStorage.For more stable fix, see in-progress #7232. The changes here simply update the problematic import to CommonJS
requiresyntax, which ensures that polyfill is in the correct order in the transpiled file. See previous issues #7038 and #6558.Testing Instructions:
Verify that the app boots while logged in, in Safari Private Mode and your preferred browser.