Add E2E tests to ensure non-admin users can log to wp-admin with no errors #10374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
Remove everything from users.json except user data. All the other data is no longer needed.
…-login-to-wp-admin
…-login-to-wp-admin
…-login-to-wp-admin
This reverts commit f5516fd.
…-login-to-wp-admin
…-login-to-wp-admin
…-login-to-wp-admin
eduardoumpierre
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5101
Changes proposed in this Pull Request
editoruser to the E2E testing environment. The neweditoruser is created during the E2E environment setup.auth.setup.tsto include logging in the editor.helpers.tsfile to login the editor and get the editor. It also adds a storage file for the editor's login data.wp-adminpages. One test is for a site that is fully onboarded to WooPayments. The second site covers the editor being able to login and viewwp-adminpages before the site is onboarded and then after the site is onboarded. These tests follow the pattern outlined in the Open admin area as non-admin critical flow test. This test spec is also tagged as critical.default.jsonfile. Since Puppeteer has been removed, the only data we need in the file is the user data. I removed all the other data and renamed it touesrs.json. I updated the reference to it inshared.shand updated the variable it was assigned to. The variable is used insetup.shso I updated variable references there as well.Testing instructions
npm run test:e2e-reset.npm run test:e2e-setupeditoruser.npm run test:e2e non-admin-wp-admin-access.specnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge