Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB8-12281: Update acl file logs #6139

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ariskataoka
Copy link
Member

Description

Updates the ACL file warnings to use log2logstash method.

Changelog Description

Changed

  • Update to use ACL file warnings to use log2logstash method.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  1. Check out PR.
  2. Go to /wp-content/uploads/file.jpg%0a
  3. Verify ACL failed.

Copy link

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.46%. Comparing base (43eeec0) to head (bfaf757).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6139      +/-   ##
=============================================
+ Coverage      30.41%   30.46%   +0.04%     
  Complexity      4830     4830              
=============================================
  Files            290      290              
  Lines          21327    21325       -2     
=============================================
+ Hits            6486     6496      +10     
+ Misses         14841    14829      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant