DRY builds S3 upload logic #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
commented
May 13, 2024
Comment on lines
-42
to
-43
|
|
||
| puts lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING] |
There was a problem hiding this comment.
By the looks of it, in particular the use of puts, this was a debugging line that sneaked in.
ef023c6 to
63b95e4
Compare
jkmassel
added a commit
that referenced
this pull request
May 13, 2024
* Isolate common Windows code * Add Release Steps with Artifacts * Better error handling * DRY builds S3 upload logic (#117) * Extract logic to distribute builds in Fastlane * DRY builds folder definition in Fastfile * Remove leftover debug `puts` * DRY S3 bucket name * Fix a comment's wording * DRY further * DRY even more * DRY commit, build, etc in Fastfile * Casing improvements --------- Co-authored-by: Gio Lodi <gio.lodi@automattic.com>
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@wojtekn mentioned that CI builds on
trunkincluded the Windows binary, but builds from tags didn't. This PR addresses the issue by DRYing the automation that uploads binaries.Update: I naively assumed the only thing to do was to upload existing files and add links. I was wrong. This PR is now stacked on top of the necessary work that @jkmassel did in #114. Goes to show one should find ways to test things locally...
What remains of this PR is centralizing the builds information in Fastlane in a Hash, so that we can iterate on each build for the S3 uploads etc, instead of copy pasting the call. While we might not need to add new builds, I still think this is a maintenability improvement.
Testing Instructions
Unfortunately, the only true way to test this is to merge it and check the artifacts, CI annotations, and Slack messages.
Pre-merge Checklist