Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap question number in <span> tag to facilitate translating with TranslatePress #7738

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Wrap question number in <span> tag to facilitate translating with TranslatePress #7738

merged 2 commits into from
Jan 15, 2025

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Jan 15, 2025 •
edited
Loading

Resolves #7622.

Proposed Changes

Wraps the question numbers in <span> tags to facilitate translating with TranslatePress.

Testing Instructions

  1. Add a question to a lesson.
  2. View it on the frontend.
  3. Check the page source and ensure the question number is wrapped in a <span> tag.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep added this to the 4.24.5 milestone Jan 15, 2025
@donnapep donnapep self-assigned this Jan 15, 2025
@donnapep donnapep mentioned this pull request Jan 15, 2025
Closed
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep merged commit cd43d10 into trunk Jan 15, 2025
23 checks passed
@donnapep donnapep deleted the update/wrap-question-title-in-span branch January 15, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donnapep donnapep

Labels
None yet
Projects
None yet
Milestone
4.24.5
Development

Successfully merging this pull request may close these issues.

Wrap Question Number in span tag
1 participant
@donnapep