Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore phpcs file system errors #7725

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Ignore phpcs file system errors #7725

merged 1 commit into from
Jan 13, 2025

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Jan 10, 2025

Resolves https://github.com/Automattic/sensei-security/issues/23

Plugin Check is suggesting to use WP_Filesystem instead of the system calls. I'm ignoring it because the class doesn't provide the needed functionality.

Proposed Changes

  • Ignore the phpcs system calls errors.

Testing Instructions

  1. Install the Plugin Check plugin.
  2. Go to Tools > Plugin Check.
  3. Select Sensei LMS from the dropdown and ensure Plugin Repo is selected.
  4. Click Check it! button.
  5. Make sure there are no WP_Filesystem errors.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@m1r0 m1r0 self-assigned this Jan 10, 2025
@m1r0 m1r0 added this to the 4.24.5 milestone Jan 10, 2025
Copy link

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 marked this pull request as ready for review January 10, 2025 15:42
@m1r0 m1r0 requested a review from donnapep January 10, 2025 15:42
Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy!

@m1r0 m1r0 merged commit 238d476 into trunk Jan 13, 2025
22 of 24 checks passed
@m1r0 m1r0 deleted the fix/filesystem-linter-errors branch January 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants