Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unsupported Features From Core Blocks #11

Merged
merged 4 commits into from
Apr 13, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove completed TODO comments
  • Loading branch information
jeffersonrabb committed Apr 13, 2020
commit 5ccbd08eb319c4954d9fb26931e4b38316bf0515
15 changes: 1 addition & 14 deletions includes/class-newspack-newsletters-renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,6 @@ private static function render_mjml_component( $block, $is_in_column = false, $i
case 'core/buttons':
// TODO disable/handle/warn for:
// - layouts.
jeffersonrabb marked this conversation as resolved.
Show resolved Hide resolved
// - align right, align left (it will always be center aligned, in columns. mjml does not handle one next to another).
// - gradients.

foreach ( $inner_blocks as $button_block ) {
// Parse block content.
Expand Down Expand Up @@ -317,14 +315,7 @@ private static function render_mjml_component( $block, $is_in_column = false, $i
* Separator block.
*/
case 'core/separator':
// TODO disable/handle/warn for:
// - dots style - it wont be supported.
$is_style_default = true;
$divider_attrs = [];
if ( isset( $attrs['className'] ) ) {
$is_style_default = 'is-style-default' == $attrs['className'];
$divider_attrs['css-class'] = $attrs['className'];
}
$is_style_default = true;
$divider_attrs = array_merge(
array(
'padding' => '0',
Expand All @@ -343,10 +334,6 @@ private static function render_mjml_component( $block, $is_in_column = false, $i
* Social links block.
*/
case 'core/social-links':
// TODO disable/handle/warn for:
// - styles. Pill could be supported, though.
// - align right, align left (it will always be center aligned, in columns. mjml does not handle one next to another).

$social_icons = array(
'wordpress' => array(
'color' => '#3499cd',
Expand Down