Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove related listings functionality #256

Merged
merged 7 commits into from
May 25, 2022
Merged

refactor: remove related listings functionality #256

merged 7 commits into from
May 25, 2022

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented May 12, 2022 •
edited by gamebits
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR deprecates the half-implemented Related Listings feature set from #58. We may decide to revive this feature in the future, preferably with a closer eye toward reader experience, but for now it's causing more confusion (and bugs) than doing anything productive.

Closes #236 and #96.

How to test the changes in this Pull Request:

  1. Check out this branch.
  2. Edit a listing and confirm that the "Related Content" panel and the UI to manage parent/child listings is gone.
  3. Make some changes to the listing, publish a new listing, view on the front-end, and do a quick smoke test to make sure that no other listings functionality is missing or broken—this is a pretty self-contained set of features, so it shouldn't affect much of anything.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the refactor Doesn't include major functional changes label May 12, 2022
@dkoo dkoo requested a review from a team as a code owner May 12, 2022 21:57
@dkoo dkoo self-assigned this May 12, 2022
@dkoo dkoo linked an issue May 12, 2022 that may be closed by this pull request
Terminology: "Related Content" #96
Closed
@adekbadek adekbadek mentioned this pull request May 23, 2022
Closed
miguelpeixe
miguelpeixe requested changes May 23, 2022
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

There's a piece remaining, I still see an empty section for "Related Content Settings" at the listings settings page:

image

@dkoo
Copy link
Contributor Author

dkoo commented May 25, 2022

There's a piece remaining, I still see an empty section for "Related Content Settings" at the listings settings page:

Whoops, thanks for catching! bfbb4fe removes the empty section from the Settings page.

@dkoo dkoo requested a review from miguelpeixe May 25, 2022 16:50
miguelpeixe
miguelpeixe approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@dkoo dkoo merged commit 25f4be8 into master May 25, 2022
@dkoo dkoo deleted the remove/shadow-taxonomies branch May 25, 2022 17:16
matticbot pushed a commit that referenced this pull request May 25, 2022
@semantic-release-bot
chore(release): 2.11.0-alpha.1 [skip ci]
b2810fd 
# [2.11.0-alpha.1](v2.10.0...v2.11.0-alpha.1) (2022-05-25)

### Features

* enable jetpack share buttons on listings ([#257](#257)) ([0dac9fb](0dac9fb))
* remove related listings functionality ([#256](#256)) ([25f4be8](25f4be8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dkoo dkoo mentioned this pull request May 30, 2022
Merged
6 tasks
matticbot pushed a commit that referenced this pull request May 30, 2022
@semantic-release-bot
chore(release): 2.11.0 [skip ci]
c847b94 
# [2.11.0](v2.10.0...v2.11.0) (2022-05-30)

### Bug Fixes

* restore Related Content settings section, but only if Jetpack Related Posts is on ([#263](#263)) ([877b71b](877b71b))

### Features

* enable jetpack share buttons on listings ([#257](#257)) ([0dac9fb](0dac9fb))
* remove related listings functionality ([#256](#256)) ([25f4be8](25f4be8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees

@dkoo dkoo

Labels
refactor Doesn't include major functional changes released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "Hide Related Listings" toggle Terminology: "Related Content"
3 participants
@dkoo @matticbot @miguelpeixe